From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: patch for nsterm.m to fix visual-bell Date: Tue, 30 Jun 2009 22:19:23 +0200 Message-ID: References: <5CB755FC-9A86-4DD5-8F16-69EC81BD77EB@zenspider.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1246393715 21314 80.91.229.12 (30 Jun 2009 20:28:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 30 Jun 2009 20:28:35 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ryan Davis Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 30 22:28:28 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from mail-forward2.uio.no ([129.240.10.71]) by lo.gmane.org with esmtp (Exim 4.50) id 1MLjvk-0005qX-Gb for ged-emacs-devel@m.gmane.org; Tue, 30 Jun 2009 22:27:52 +0200 Original-Received: from exim by mail-out2.uio.no with local-bsmtp (Exim 4.69) (envelope-from ) id 1MLjp7-0004xl-MA for ged-emacs-devel@m.gmane.org; Tue, 30 Jun 2009 22:21:01 +0200 Original-Received: from mail-mx1.uio.no ([129.240.10.29]) by mail-out2.uio.no with esmtp (Exim 4.69) (envelope-from ) id 1MLjp7-0004xi-LC for ged-emacs-devel@m.gmane.org; Tue, 30 Jun 2009 22:21:01 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by mail-mx1.uio.no with esmtps (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1MLjp6-0003xa-Tz for ged-emacs-devel@m.gmane.org; Tue, 30 Jun 2009 22:21:01 +0200 Original-Received: from localhost ([127.0.0.1]:40338 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MLjp5-0006xA-GX for ged-emacs-devel@m.gmane.org; Tue, 30 Jun 2009 16:20:59 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MLjnd-0005G8-2D for emacs-devel@gnu.org; Tue, 30 Jun 2009 16:19:29 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MLjnY-0005A0-8g for emacs-devel@gnu.org; Tue, 30 Jun 2009 16:19:28 -0400 Original-Received: from [199.232.76.173] (port=58793 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MLjnY-00059k-4X for emacs-devel@gnu.org; Tue, 30 Jun 2009 16:19:24 -0400 Original-Received: from smtp-03.vtx.ch ([212.147.0.64]:51991) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MLjnX-0006PX-W0 for emacs-devel@gnu.org; Tue, 30 Jun 2009 16:19:24 -0400 Original-Received: from alfajor.home (dyn.83-228-217-245.dsl.vtx.ch [83.228.217.245]) by smtp-03.vtx.ch (VTX Services SA) with ESMTP id 3B830296CDF; Tue, 30 Jun 2009 22:19:23 +0200 (CEST) Original-Received: by alfajor.home (Postfix, from userid 20848) id 15DD764344; Tue, 30 Jun 2009 22:19:23 +0200 (CEST) In-Reply-To: <5CB755FC-9A86-4DD5-8F16-69EC81BD77EB@zenspider.com> (Ryan Davis's message of "Mon, 29 Jun 2009 20:53:23 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.94 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-UiO-Spam-info: not spam, SpamAssassin (score=-4.0, required=5.0, autolearn=disabled, RCVD_IN_DNSWL_MED=-4, uiobl=NO, uiouri=_URIID_) X-UiO-Scanned: 943810CBF39D956BCE39E3042FCF9E471D53E2F6 X-UiO-SPAM-Test: remote_host: 199.232.76.165 spam_score: -39 maxlevel 80 minaction 2 bait 0 mail/h: 16 total 102238 max/h 424 blacklist 0 greylist 0 ratelimit 0 Xref: news.gmane.org gmane.emacs.devel:111838 Archived-At: > This patch changes it to be 1 line height at the bottom of the window over > the minibuffer much like the previous visual-bell in 22.3. 22.3 also has > a line at the top but I didn't want to futz with the patch more than I had > to lest it not get accepted. The patch is available at: That sounds fairly good. I'd still expect the visual-bell to be implemented in the generic code, but in the mean time, this looks good to me. What do others think? Stefan