From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#4599: 23.1.50; VC (CVS) fails to show directory status Date: Wed, 30 Sep 2009 22:19:03 -0400 Message-ID: References: <877hvgzj5a.fsf@leeloo.anubex.internal> <200909301653.n8UGrwU0018764@godzilla.ics.uci.edu> Reply-To: Stefan Monnier , 4599@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1254364550 22355 80.91.229.12 (1 Oct 2009 02:35:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 1 Oct 2009 02:35:50 +0000 (UTC) Cc: Tim Van Holder , 4599@emacsbugs.donarmstrong.com To: Dan Nicolaescu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 01 04:35:43 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MtBWA-0001mS-9m for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Oct 2009 04:35:42 +0200 Original-Received: from localhost ([127.0.0.1]:56926 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MtBW9-0003u7-NH for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Sep 2009 22:35:41 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MtBNz-0006Xp-P9 for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2009 22:27:15 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MtBNu-0006TB-AX for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2009 22:27:14 -0400 Original-Received: from [199.232.76.173] (port=42984 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MtBNu-0006So-47 for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2009 22:27:10 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:55847) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MtBNt-0004sR-MZ for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2009 22:27:10 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n912R7Ee030070; Wed, 30 Sep 2009 19:27:07 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n912P5k3029543; Wed, 30 Sep 2009 19:25:05 -0700 Resent-Date: Wed, 30 Sep 2009 19:25:05 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Thu, 01 Oct 2009 02:25:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4599 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4599-submit@emacsbugs.donarmstrong.com id=B4599.125436355128787 (code B ref 4599); Thu, 01 Oct 2009 02:25:04 +0000 Original-Received: (at 4599) by emacsbugs.donarmstrong.com; 1 Oct 2009 02:19:11 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ironport2-out.pppoe.ca (ironport2-out.teksavvy.com [206.248.154.181]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n912J9tN028784 for <4599@emacsbugs.donarmstrong.com>; Wed, 30 Sep 2009 19:19:11 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEAK6uw0pMCrXH/2dsb2JhbACBT9VchCcEhw+Cag X-IronPort-AV: E=Sophos;i="4.44,483,1249272000"; d="scan'208";a="46880750" Original-Received: from 76-10-181-199.dsl.teksavvy.com (HELO pastel.home) ([76.10.181.199]) by ironport2-out.pppoe.ca with ESMTP; 30 Sep 2009 22:19:04 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id E95998109; Wed, 30 Sep 2009 22:19:03 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Wed, 30 Sep 2009 15:59:18 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Wed, 30 Sep 2009 22:27:14 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31608 Archived-At: >> in particular the removal or the expand-file-name calls is incorrect. >> At least ~ needs to be expanded, otherwise things just do not work. > While it might be the immediate cause of the problem, I think the > removal of expand-file-name calls might still be right: the code that > sets default-directory to a value starting with "~/" might be the one > that should be changed. The patch below indeed seems to fix the problem. Stefan === modified file 'lisp/files.el' --- lisp/files.el 2009-09-30 14:51:08 +0000 +++ lisp/files.el 2009-10-01 02:15:33 +0000 @@ -648,7 +648,12 @@ ;; Put the name into directory syntax now, ;; because otherwise expand-file-name may give some bad results. (setq dir (file-name-as-directory dir)) - (setq dir (abbreviate-file-name (expand-file-name dir))) + ;; We used to additionally call abbreviate-file-name here, for an + ;; unknown reason. Problem is that most buffers are setup + ;; without going through cd-absolute and don't call + ;; abbreviate-file-name on their default-directory, so the few that + ;; do end up using a superficially different directory. + (setq dir (expand-file-name dir)) (if (not (file-directory-p dir)) (if (file-exists-p dir) (error "%s is not a directory" dir)