From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: log-edit-strip-single-file-name Date: Fri, 29 Jan 2010 12:58:15 -0500 Message-ID: References: <3a26oiti.fsf@fencepost.gnu.org> <12bpggw4wg.fsf@fencepost.gnu.org> <201001290820.o0T8KCv1022959@godzilla.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1264787918 24636 80.91.229.12 (29 Jan 2010 17:58:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Jan 2010 17:58:38 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 29 18:58:34 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Nav72-0004HV-FI for ged-emacs-devel@m.gmane.org; Fri, 29 Jan 2010 18:58:32 +0100 Original-Received: from localhost ([127.0.0.1]:60382 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nav71-0007nz-SQ for ged-emacs-devel@m.gmane.org; Fri, 29 Jan 2010 12:58:31 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nav6w-0007nf-5y for emacs-devel@gnu.org; Fri, 29 Jan 2010 12:58:26 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Nav6r-0007kg-IQ for emacs-devel@gnu.org; Fri, 29 Jan 2010 12:58:25 -0500 Original-Received: from [199.232.76.173] (port=52687 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nav6r-0007kW-BN for emacs-devel@gnu.org; Fri, 29 Jan 2010 12:58:21 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:41927) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nav6o-00034p-IZ; Fri, 29 Jan 2010 12:58:18 -0500 Original-Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id o0THwFq9005763; Fri, 29 Jan 2010 12:58:15 -0500 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 624F73A7A3; Fri, 29 Jan 2010 12:58:15 -0500 (EST) In-Reply-To: <201001290820.o0T8KCv1022959@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Fri, 29 Jan 2010 00:20:12 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3459=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:120660 Archived-At: >> >>> Should I be setting log-edit-strip-single-file-name to nil when using >> > [...] >> >>> If so, it should probably be in Emacs's .dir-locals.el. >> >> Agreed, >> > It doesn't work. I guess dir-locals doesn't affect buffers not >> > visiting files. >> >> This is a "general" problem that we may want to solve: non-file (nor >> dired) buffers that are (loosely) associated with a particular >> directory should probably obey .dir-locals.el. > How about solvin specific instances of this problem by calling > `hack-dir-local-variables' from `log-edit-mode' and other VC related > modes? Doesn't sound too bad. Just try and make sure the log-edit part of the code is as clean as possible (i.e. modify hack-dir-local-variables or provide a wrapper or a different function if extra work is needed), so we have a clear path to add that functionality on other codes (e.g. vc-dir, diff-mode, ...). Stefan