From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Thierry Volpiatto <thierry.volpiatto@gmail.com>
Cc: bug-gnu-emacs@gnu.org
Subject: bug#5591: 23.1.92; bookmark.el and file path
Date: Thu, 18 Feb 2010 09:00:45 -0500 [thread overview]
Message-ID: <jwvfx4yzltn.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87tytflcrm.fsf@tux.homenetwork> (Thierry Volpiatto's message of "Wed, 17 Feb 2010 23:26:37 +0100")
> is there any reason to expand-file-name here in bookmark-relocate?
> ,----
> | (let* ((bmrk-filename (bookmark-get-filename bookmark))
> | (newloc (expand-file-name ==> here
> | (read-file-name
> | (format "Relocate %s to: " bookmark)
> | (file-name-directory bmrk-filename)))))
> `----
> Work fine without here.
read-file-name can return a relative file name, so yes, expand-file-name
is needed. So the solution is to add a call to abbreviate-file-name.
Stefan
next prev parent reply other threads:[~2010-02-18 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 19:48 bug#5591: 23.1.92; bookmark.el and file path Leo
2010-02-17 22:26 ` Thierry Volpiatto
2010-02-18 14:00 ` Stefan Monnier [this message]
2010-02-18 18:54 ` Stefan Monnier
2010-02-20 11:18 ` Leo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvfx4yzltn.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=bug-gnu-emacs@gnu.org \
--cc=thierry.volpiatto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.