From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Emacs tool bar on Fedora14 Date: Tue, 16 Nov 2010 10:24:33 -0500 Message-ID: References: <4CDADD76.9070809@alice.it> <4CDAF28C.8040405@swipnet.se> <4CDD7CE5.4050809@swipnet.se> <4CE2276F.1010008@swipnet.se> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1289921087 13569 80.91.229.12 (16 Nov 2010 15:24:47 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 16 Nov 2010 15:24:47 +0000 (UTC) Cc: Emacs , "Andrew W. Nosenko" , Angelo Graziosi To: Jan =?iso-8859-1?Q?Dj=E4rv?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 16 16:24:42 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PINOj-0000Ja-LA for ged-emacs-devel@m.gmane.org; Tue, 16 Nov 2010 16:24:41 +0100 Original-Received: from localhost ([127.0.0.1]:46490 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PINOi-00052n-OK for ged-emacs-devel@m.gmane.org; Tue, 16 Nov 2010 10:24:40 -0500 Original-Received: from [140.186.70.92] (port=52770 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PINOe-00052i-N8 for emacs-devel@gnu.org; Tue, 16 Nov 2010 10:24:37 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PINOd-0003Ui-Lr for emacs-devel@gnu.org; Tue, 16 Nov 2010 10:24:36 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:47475 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PINOd-0003UY-Gh for emacs-devel@gnu.org; Tue, 16 Nov 2010 10:24:35 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AlUJABox4kxFpY76/2dsb2JhbAChY3tyv0mFSwSEWjiNKA X-IronPort-AV: E=Sophos;i="4.59,206,1288584000"; d="scan'208";a="82672820" Original-Received: from 69-165-142-250.dsl.teksavvy.com (HELO pastel.home) ([69.165.142.250]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 16 Nov 2010 10:24:34 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id DB92EA82A9; Tue, 16 Nov 2010 10:24:33 -0500 (EST) In-Reply-To: <4CE2276F.1010008@swipnet.se> ("Jan =?iso-8859-1?Q?Dj=E4rv=22?= =?iso-8859-1?Q?'s?= message of "Tue, 16 Nov 2010 07:40:47 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132724 Archived-At: > We don't use Gtk+ tool bar functions to display the text because they are > too limited. Not showing text is not that hard anyway. I'm not sure I understand what you're trying to say. To get back to my argument: since both-horiz is the default, we should be careful to make it work well enough, similarly to other Gtk apps, by only showing some of the labels but not all. Whether that is done by using gtk_tool_item_[gs]et_is_important (and/or Gtk's toolbar functions to display the text) is rather secondary. Of course, as a general rule, if we can reuse other people's code, it's better, but indeed it's not always convenient. Stefan > Andrew W. Nosenko skrev 2010-11-16 00.45: >> On Fri, Nov 12, 2010 at 22:39, Stefan Monnier wrote: >>>>> ** GTK tool bars can have just text, just images or images and text. >>>>> Customize `tool-bar-style' to choose style. On a Gnome desktop, the >>>>> default is taken from the desktop settings. >>>>> BTW, I couldn't figure out how to customize it in Gnome. I do remember >>>>> seeing such an option somewhere (maybe in gnome-appearance-properties) >>>>> at some point in the past, but I can't seem to find it any more. >>>> There used to be an Interface tab in Appearance but it has been removed by >>>> the Gnome people. I guess that is logical, as they seem to move >>>> towards a customization-free desktop. They decided that both-horiz (icon >>>> followed by text) is what everybody should have. >>>> Now you have to edit gconf directly either with gconf-editor or with >>> >>>> % gconftool-2 --set --type string /desktop/gnome/interface/toolbar_style both >>> >>>> Other values are both-horiz, text or icons. >>> >>> I think we should mention it in our documentation. And I also think >>> there's something more going on: when I try gedit with various settings >>> of /desktop/gnome/interface/toolbar_style, it's clear that in both-horiz >>> setting, only some of the buttons get their text, whereas with Emacs >>> they all do. >>> That means that both-horiz is quite bearable with gedit but not >>> with Emacs. And since both-horiz is the default, I think we need to >>> figure out how to do the same as gedit does (i.e. specify which toolbar >>> buttons need to have the text displayed in both-horiz and which don't). >> >> http://library.gnome.org/devel/gtk/stable/GtkToolItem.html >> gtk_tool_item_set_is_important() >> gtk_tool_item_get_is_important() >> "is-important" property >>