From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Any objection to adding completing-read-function? Date: Thu, 09 Jun 2011 12:16:30 -0300 Message-ID: References: <21E601B384E14788A5CDF8AD49535D75@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1307633211 12375 80.91.229.12 (9 Jun 2011 15:26:51 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 9 Jun 2011 15:26:51 +0000 (UTC) Cc: Drew Adams , emacs-devel@gnu.org To: Leo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 09 17:26:46 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QUh8A-0000fr-2R for ged-emacs-devel@m.gmane.org; Thu, 09 Jun 2011 17:26:46 +0200 Original-Received: from localhost ([::1]:50016 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUh88-0007lZ-Mu for ged-emacs-devel@m.gmane.org; Thu, 09 Jun 2011 11:26:45 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:35297) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUgyL-0005F1-Eu for emacs-devel@gnu.org; Thu, 09 Jun 2011 11:16:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QUgyK-0008D1-1P for emacs-devel@gnu.org; Thu, 09 Jun 2011 11:16:37 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:54897) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUgyJ-0008Cv-Ok for emacs-devel@gnu.org; Thu, 09 Jun 2011 11:16:35 -0400 Original-Received: from 213-159-126-200.fibertel.com.ar ([200.126.159.213]:52289 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QUgyI-0007CC-Oq; Thu, 09 Jun 2011 11:16:35 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 85DB3667EF; Thu, 9 Jun 2011 12:16:30 -0300 (ART) In-Reply-To: (Leo's message of "Thu, 09 Jun 2011 19:53:22 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:140321 Archived-At: >>> Full agreement. I'd like to turn the `initial' arg into a callback >>> (which can do initialization in a similar way to >>> minibuffer-with-setup-hook, but more robust) but doing it in C is >>> more painful. >> Will look into this later on. > OK, I am going to focus on moving some of the code to elisp first. Of course. First move the code to C reproducing the behavior as faithfully as possible. >> Preliminary patch attached that moves completing-read-function and >> completing-read-default to elisp. Comments welcome. > No comments so far. Any objection if I put the patch in trunk? I haven't had a chance yet to look at it. Maybe next week. Stefan