From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 9353@debbugs.gnu.org
Subject: bug#9353: 24.0.50; default grep file name face is uglier now
Date: Tue, 23 Aug 2011 20:24:14 -0400 [thread overview]
Message-ID: <jwvfwkrllaj.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <D6261054A49249E39889E3401FF3503D@us.oracle.com> (Drew Adams's message of "Tue, 23 Aug 2011 13:18:54 -0700")
> For one thing, it should not be bold. We should almost never use a bold
> face as the default face for something, because boldness does not work
> well on some platforms and for some (many) faces.
I tend to agree, tho in this case part of the intention of grep-mode is
to make this part of the text less important since you don't need to
visit the file by hand but can just click on the link instead.
At least I think that's the only reason why noone complained about those
faces until now, even though they've been in use at least since Emacs-23.1.
> But there is also no logical connection to "success" here.
I don't know what's the connection either. Maybe it's a "match success".
> Anyway, whatever you inherit from (but why must you always inherit?),
It's good to provide structure within the space of faces, so inheritance
is an important tool that should be used whenever possible, but of
course, we need to be careful to only use it when it really makes sense.
AFAICT the `success' face was created pretty much for this, so maybe the
problem is not the inheritance link but the name of the `success' face.
> the default appearance should not be ugly and difficult to read. That
> just forces more users to customize it or live with the difficulty.
The default font I use is readable in bold, because giving up on such
a useful tool would be too bad (remember that I prefer to use the same
color everywhere and distinguish things based on bold/italics/font), but
that's just me.
I'm not opposed to tweaks for this face, tho a bright bold green seems
to work well in M-x compile (at least for my setup), so please consider
the impact on M-x compile when making those tweaks.
Stefan
next prev parent reply other threads:[~2011-08-24 0:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 20:18 bug#9353: 24.0.50; default grep file name face is uglier now Drew Adams
2011-08-23 21:32 ` Juri Linkov
2011-08-24 0:19 ` Drew Adams
2011-08-24 9:01 ` Juri Linkov
2011-08-24 14:55 ` Stefan Monnier
2011-08-24 18:02 ` Juri Linkov
2011-08-24 0:24 ` Stefan Monnier [this message]
2011-08-24 9:04 ` Juri Linkov
2011-08-24 13:38 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvfwkrllaj.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=9353@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.