From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#12135: 24.1.50; compatibility between compiled files in emacs-24.1 and 24.2 Date: Wed, 08 Aug 2012 14:57:51 -0400 Message-ID: References: <873943nh13.fsf@gmail.com> <871ujlgbrz.fsf@gmail.com> <87ipctxt73.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1344452372 11706 80.91.229.3 (8 Aug 2012 18:59:32 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 8 Aug 2012 18:59:32 +0000 (UTC) Cc: 12135-done@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 08 20:59:26 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SzBTa-0004l3-28 for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Aug 2012 20:59:26 +0200 Original-Received: from localhost ([::1]:57013 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzBTZ-0001Bk-Do for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Aug 2012 14:59:25 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzBTV-0001B8-TW for bug-gnu-emacs@gnu.org; Wed, 08 Aug 2012 14:59:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzBT7-0002LR-ND for bug-gnu-emacs@gnu.org; Wed, 08 Aug 2012 14:59:21 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33321) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzBT7-0002L4-K4 for bug-gnu-emacs@gnu.org; Wed, 08 Aug 2012 14:58:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SzBaw-0007Gl-9o for bug-gnu-emacs@gnu.org; Wed, 08 Aug 2012 15:07:02 -0400 Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Aug 2012 19:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 12135 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 12135@debbugs.gnu.org, monnier@IRO.UMontreal.CA Original-Received: via spool by 12135-done@debbugs.gnu.org id=D12135.134445276427878 (code D ref 12135); Wed, 08 Aug 2012 19:07:02 +0000 Original-Received: (at 12135-done) by debbugs.gnu.org; 8 Aug 2012 19:06:04 +0000 Original-Received: from localhost ([127.0.0.1]:42865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SzBa0-0007FZ-0c for submit@debbugs.gnu.org; Wed, 08 Aug 2012 15:06:04 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:55489) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SzBZv-0007F8-Nx for 12135-done@debbugs.gnu.org; Wed, 08 Aug 2012 15:06:02 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q78IvpqV023794; Wed, 8 Aug 2012 14:57:52 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id BD7E0B4081; Wed, 8 Aug 2012 14:57:51 -0400 (EDT) In-Reply-To: <87ipctxt73.fsf@gmail.com> (Thierry Volpiatto's message of "Wed, 08 Aug 2012 18:08:16 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4304=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4304> : streams <796357> : uri <1187205> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:62958 Archived-At: > I think at flet because there is no reason that the other part of the > code don't work. (but I may be wrong) flet is used elsewhere. And eliminating the flet (see patch below, which doesn't look bad when compared to the horror generated by flet) did not solve the problem. > Hmm! No, AFAIK there is no ignore-errors involved here. Somehow an error must have been signaled and then silenced. I replaced all ignore-errors by with-demoted-errors but that didn't help, so it must be some condition-case somewhere (or some other code in some other Elisp library, of course). In any case, I think I found the culprit: the old CL's `loop' used cl-map-keymap-recursively internally for `key-seqs', which I renamed to cl--map-keymap-recursively but forgot to add a compatibility alias. Should be fixed now, thank you, Stefan === modified file 'helm-command.el' --- helm-command.el 2012-08-04 13:51:32 +0000 +++ helm-command.el 2012-08-08 18:27:09 +0000 @@ -116,7 +116,7 @@ when (commandp com) collect i into hist finally return hist)) command sym-com) - (flet ((pers-help (candidate) + (let ((pers-help (lambda (candidate) (let ((hbuf (get-buffer (help-buffer))) special-display-buffer-names special-display-regexps) @@ -136,14 +136,14 @@ (describe-function (intern candidate)) (message nil) ; Erase the new stupid message Type "q"[...] (setq in-help t)) - (setq help-cand candidate)))) + (setq help-cand candidate))))) (setq command (helm-comp-read "M-x " obarray :test 'commandp :requires-pattern helm-M-x-requires-pattern :name "Emacs Commands" :buffer "*helm M-x*" - :persistent-action 'pers-help + :persistent-action pers-help :persistent-help "Describe this command" :history history :del-input nil