From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: PATCH: num3-mode for highlighting groups of digits in long numbers Date: Wed, 26 Sep 2012 16:01:29 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1348694060 5332 80.91.229.3 (26 Sep 2012 21:14:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 26 Sep 2012 21:14:20 +0000 (UTC) Cc: Noah Lavine , emacs-devel@gnu.org, Felix Lee To: Michal Nazarewicz Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 26 23:14:24 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TGyw3-0003yE-0i for ged-emacs-devel@m.gmane.org; Wed, 26 Sep 2012 23:14:23 +0200 Original-Received: from localhost ([::1]:40505 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGyvx-0005aj-MX for ged-emacs-devel@m.gmane.org; Wed, 26 Sep 2012 17:14:17 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGyvv-0005aN-4k for emacs-devel@gnu.org; Wed, 26 Sep 2012 17:14:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGyvr-0004da-3u for emacs-devel@gnu.org; Wed, 26 Sep 2012 17:14:15 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:38049) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGyvq-0004dU-Oh for emacs-devel@gnu.org; Wed, 26 Sep 2012 17:14:11 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q8QK1T5X030751; Wed, 26 Sep 2012 16:01:29 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id B11BCB404D; Wed, 26 Sep 2012 16:01:29 -0400 (EDT) In-Reply-To: (Michal Nazarewicz's message of "Wed, 26 Sep 2012 15:06:19 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153605 Archived-At: > Sorry, you're absolutely right. It's mistake in documentation in my > part. Attached is fixed version of the file. Thanks, I just added it to the `elpa' so it should appear in GNU ELPA next time someone refreshes it. I made the following changes: - Added a "Version: 1.0" header. - Removed the (require 'font-lock) that seemed unnecessary. - Removed turn-on-num3-mode since (num3-mode) does the same anyway. I do see that when num3-mode is already enabled (turn-on-num3-mode) did nothing whereas (num3-mode) will call font-lock-fontify-buffer but if that's a problem, we should fix num3-mode. I'm not sure what the "-num-" prefix is meant to be and I'm not fond of it. If it's meant for internal functions, then please use "num--" instead. > checkdoc-current-buffer gives me two errors but I'm not sure how to fix > those since in given instances num3-mode refers to the mode. Don't take checkdoc for the gospel; those "errors" are fine. If you do want to fix them, do as told: add the word "function" or "command" soon before the offending `num3-mode'. If you want to maintain the file directly in the elpa branch (rather than send us patches), then please ask for write access (by registering an account on savannah, and asking for membership in the "emacs" group from that account). Thank you for your contribution, Stefan