From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Someone broke erc-match Date: Tue, 12 Feb 2013 23:02:31 -0500 Message-ID: References: <87halhq8nv.fsf@dimension8.tehua.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1360728162 17202 80.91.229.3 (13 Feb 2013 04:02:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Feb 2013 04:02:42 +0000 (UTC) Cc: emacs-devel@gnu.org To: Aidan Gauland Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 13 05:03:03 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U5TYg-0003rm-Js for ged-emacs-devel@m.gmane.org; Wed, 13 Feb 2013 05:02:58 +0100 Original-Received: from localhost ([::1]:60394 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U5TYN-0002Hu-77 for ged-emacs-devel@m.gmane.org; Tue, 12 Feb 2013 23:02:39 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:42276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U5TYL-0002He-Bd for emacs-devel@gnu.org; Tue, 12 Feb 2013 23:02:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U5TYJ-0008Jd-EJ for emacs-devel@gnu.org; Tue, 12 Feb 2013 23:02:37 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:12898) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U5TYJ-0008JU-A2 for emacs-devel@gnu.org; Tue, 12 Feb 2013 23:02:35 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFpYjU/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBrEfkA6RCgOIYZwZgV6DFQ X-IPAS-Result: Av4EABK/CFFFpYjU/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBrEfkA6RCgOIYZwZgV6DFQ X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="1133849" Original-Received: from 69-165-136-212.dsl.teksavvy.com (HELO pastel.home) ([69.165.136.212]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 12 Feb 2013 23:02:33 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 9D5A559267; Tue, 12 Feb 2013 23:02:31 -0500 (EST) In-Reply-To: <87halhq8nv.fsf@dimension8.tehua.net> (Aidan Gauland's message of "Wed, 13 Feb 2013 14:55:48 +1300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:156997 Archived-At: > - (re-search-forward (regexp-quote nickname) > + (re-search-forward "\\(\\* \\)?"(regexp-quote nickname) [...] > It's not clear what was intended, so I cannot suggest a fix (aside from > simply reverting). Sorry, I wish I could say my cat did it. I obviously wasn't really awake when I installed your patch (I also messed up the ChangeLog part). > I also submitted a patch that supersedes my patch, which actually caused > an out-of-range error for every non-ACTION message. Obviously worse > than truncating ACTION messages. Here's my patch fix: Thanks, installed, hopefully I did it right this time! Stefan