From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Aidan Gauland <aidalgol@no8wireless.co.nz>
Cc: emacs-devel@gnu.org
Subject: Re: Someone broke erc-match
Date: Tue, 12 Feb 2013 23:02:31 -0500 [thread overview]
Message-ID: <jwvfw10sw0q.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87halhq8nv.fsf@dimension8.tehua.net> (Aidan Gauland's message of "Wed, 13 Feb 2013 14:55:48 +1300")
> - (re-search-forward (regexp-quote nickname)
> + (re-search-forward "\\(\\* \\)?"(regexp-quote nickname)
[...]
> It's not clear what was intended, so I cannot suggest a fix (aside from
> simply reverting).
Sorry, I wish I could say my cat did it. I obviously wasn't really
awake when I installed your patch (I also messed up the ChangeLog part).
> I also submitted a patch that supersedes my patch, which actually caused
> an out-of-range error for every non-ACTION message. Obviously worse
> than truncating ACTION messages. Here's my patch fix:
Thanks, installed, hopefully I did it right this time!
Stefan
prev parent reply other threads:[~2013-02-13 4:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 1:55 Someone broke erc-match Aidan Gauland
2013-02-13 4:02 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvfw10sw0q.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=aidalgol@no8wireless.co.nz \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.