From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/emacs-24 r111281: * progmodes/python.el (python-info-current-defun): Fix failed Date: Tue, 19 Feb 2013 16:37:44 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1361309878 11632 80.91.229.3 (19 Feb 2013 21:37:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 Feb 2013 21:37:58 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?iso-8859-1?Q?Fabi=E1n?= Ezequiel Gallina Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 19 22:38:18 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U7utD-0001Zw-Bo for ged-emacs-devel@m.gmane.org; Tue, 19 Feb 2013 22:38:15 +0100 Original-Received: from localhost ([::1]:40199 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7ust-0000Sv-5T for ged-emacs-devel@m.gmane.org; Tue, 19 Feb 2013 16:37:55 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:41544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7uso-0000SL-9r for emacs-devel@gnu.org; Tue, 19 Feb 2013 16:37:53 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U7usm-0006gD-AP for emacs-devel@gnu.org; Tue, 19 Feb 2013 16:37:50 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:50905) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7usm-0006g9-6n for emacs-devel@gnu.org; Tue, 19 Feb 2013 16:37:48 -0500 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r1JLbjTW018421; Tue, 19 Feb 2013 16:37:45 -0500 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 01180B40CF; Tue, 19 Feb 2013 16:37:44 -0500 (EST) In-Reply-To: (=?iso-8859-1?Q?=22F?= =?iso-8859-1?Q?abi=E1n?= Ezequiel Gallina"'s message of "Tue, 19 Feb 2013 15:53:57 -0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4497=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4497> : streams <909751> : uri <1350148> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:157172 Archived-At: > - (python-nav-end-of-defun) > + (save-match-data > + ;; FIXME: avoid cluttering match-data > + ;; where's not wanted. > + (python-nav-end-of-defun)) > (+ (point) > (if (>= (current-indentation) min-indent) > (1+ (current-indentation)) I suspect this is not The Right Place for the save-match-data, since we should not assume that current-indentation won't also mess up the match-data. Stefan