From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: "Fabián Ezequiel Gallina" <fabian@anue.biz>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/emacs-24 r111281: * progmodes/python.el (python-info-current-defun): Fix failed
Date: Tue, 19 Feb 2013 16:37:44 -0500 [thread overview]
Message-ID: <jwvfw0s9eaa.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1U7sgy-00020G-Up@vcs.savannah.gnu.org> ("Fabián Ezequiel Gallina"'s message of "Tue, 19 Feb 2013 15:53:57 -0300")
> - (python-nav-end-of-defun)
> + (save-match-data
> + ;; FIXME: avoid cluttering match-data
> + ;; where's not wanted.
> + (python-nav-end-of-defun))
> (+ (point)
> (if (>= (current-indentation) min-indent)
> (1+ (current-indentation))
I suspect this is not The Right Place for the save-match-data, since we
should not assume that current-indentation won't also mess up the
match-data.
Stefan
next parent reply other threads:[~2013-02-19 21:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1U7sgy-00020G-Up@vcs.savannah.gnu.org>
2013-02-19 21:37 ` Stefan Monnier [this message]
2013-02-20 5:24 ` [Emacs-diffs] /srv/bzr/emacs/emacs-24 r111281: * progmodes/python.el (python-info-current-defun): Fix failed Fabián Ezequiel Gallina
2013-02-20 14:01 ` Stefan Monnier
2013-02-20 20:54 ` Fabián Ezequiel Gallina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvfw0s9eaa.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=fabian@anue.biz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.