From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: Alan Mackenzie <acm@muc.de>, Paul Eggert <eggert@cs.ucla.edu>,
14886@debbugs.gnu.org
Subject: bug#14886: Fwd: bug#14886: Fwd: A significant slowdown calling font-lock-fontify-buffer from a hook
Date: Wed, 24 Jul 2013 21:24:37 -0400 [thread overview]
Message-ID: <jwvfvv3phko.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAAeL0SRqovcsARVn5YcWTV3paAot4S-8Ez+2p4+1hvL7gQSeGQ@mail.gmail.com> (Juanma Barranquero's message of "Wed, 24 Jul 2013 23:29:00 +0200")
> - Font-lock-fontify-buffer should not be called from a hook.
Font-lock-fontify-buffer is definitely a bad function, since it has
2 different meanings (either "make sure the buffer is fontified" or
"please refontify the buffer"). It should be replaced by two different
functions:
- font-lock-ensure-fontification, which makes sure fontification is
applied to a particular region (e.g. for use by things like
htmlfontify or ps-print).
- font-lock-flush-fontification which indicates that the fontification
for a particular region should be considered out-of-date (e.g. for use
after calling font-lock-add/remove-keywords).
I don't see why any of those 3 functions shouldn't be called from
a hook, tho.
> - Errors during fontification should be visible. That would have made
> clear that there was something wrong with the 24.3 use case.
Silent errors are bugs. Please try and find what happens with
the error message.
Stefan
next prev parent reply other threads:[~2013-07-25 1:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 0:12 A significant slowdown calling font-lock-fontify-buffer from a hook Juanma Barranquero
2013-07-16 18:01 ` Eli Zaretskii
2013-07-16 18:26 ` Juanma Barranquero
2013-07-16 18:47 ` Eli Zaretskii
2013-07-16 23:03 ` bug#14886: Fwd: " Juanma Barranquero
2013-07-17 3:05 ` Juanma Barranquero
2013-07-17 4:02 ` Eli Zaretskii
2013-07-17 9:04 ` Juanma Barranquero
2013-07-17 11:42 ` Juanma Barranquero
2013-07-17 12:50 ` Paul Eggert
2013-07-17 13:43 ` Juanma Barranquero
2013-07-17 13:59 ` Paul Eggert
2013-07-17 15:19 ` Juanma Barranquero
2013-07-17 15:57 ` Glenn Morris
2013-07-17 16:56 ` Juanma Barranquero
2013-07-22 4:20 ` Stefan Monnier
2013-07-22 22:11 ` Juanma Barranquero
[not found] ` <CAAeL0STtrBnWTbc0FSPn6XHArcDtxHwzNVaijvyG5bVKMLRo+w@mail.gmail.com>
2013-07-24 19:30 ` bug#14886: Fwd: " Alan Mackenzie
2013-07-24 21:29 ` Juanma Barranquero
2013-07-25 1:24 ` Stefan Monnier [this message]
2013-07-25 6:53 ` Juanma Barranquero
2013-07-26 19:44 ` Alan Mackenzie
2013-07-26 21:32 ` Juanma Barranquero
2013-07-27 9:35 ` Alan Mackenzie
2013-07-27 10:10 ` Juanma Barranquero
2013-07-27 10:20 ` martin rudalics
2013-07-27 14:03 ` Stefan Monnier
2013-07-28 9:58 ` Alan Mackenzie
2019-10-30 12:52 ` Lars Ingebrigtsen
2013-07-17 15:04 ` Eli Zaretskii
2013-07-17 15:16 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvfvv3phko.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=14886@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=eggert@cs.ucla.edu \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.