From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.help Subject: Re: sml-mode indentation for structures Date: Mon, 06 Oct 2014 14:11:28 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1412619146 1559 80.91.229.3 (6 Oct 2014 18:12:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 6 Oct 2014 18:12:26 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Mon Oct 06 20:12:19 2014 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XbCld-00072L-G8 for geh-help-gnu-emacs@m.gmane.org; Mon, 06 Oct 2014 20:12:17 +0200 Original-Received: from localhost ([::1]:53562 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbCld-0005Q3-15 for geh-help-gnu-emacs@m.gmane.org; Mon, 06 Oct 2014 14:12:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbClE-0005EP-Ku for help-gnu-emacs@gnu.org; Mon, 06 Oct 2014 14:12:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XbCl6-0000Dw-F9 for help-gnu-emacs@gnu.org; Mon, 06 Oct 2014 14:11:52 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:44289) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbCl6-0000Di-8Z for help-gnu-emacs@gnu.org; Mon, 06 Oct 2014 14:11:44 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XbCl5-0006je-Is for help-gnu-emacs@gnu.org; Mon, 06 Oct 2014 20:11:43 +0200 Original-Received: from 69-196-168-232.dsl.teksavvy.com ([69.196.168.232]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 06 Oct 2014 20:11:43 +0200 Original-Received: from monnier by 69-196-168-232.dsl.teksavvy.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 06 Oct 2014 20:11:43 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 18 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 69-196-168-232.dsl.teksavvy.com User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) Cancel-Lock: sha1:tcaI1Zxo1i8Lg3SK7i/xAyDwG5U= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:100316 Archived-At: >>>> (add-function :around smie-indent-rules #'my-sml-rules))) >>> I only had to replace smie-indent-rules with >>> (symbol-function 'sml-smie-rules). >> Oh, sorry, it should have been `smie-rules-function'. >> Using (symbol-function 'sml-smie-rules) instead, ends up being more like >> the `defadvice' case: it modifies the behavior of sml-mode globally >> rather than only in the buffer where we run the code. > I see. Actually I run the code with eval-after-load; but, yes, using > sml-mode-hook feels cleaner. BTW: (add-function (symbol-function ) ) is generally better written as (advice-add ). The difference is that advice-add will work even if is not yet defined (i.e. no need for eval-after-load), and it will work if is autoloaded, and if it's a macro, etc... Stefan