From: Stefan Monnier <monnier@iro.umontreal.ca>
To: help-gnu-emacs@gnu.org
Subject: Re: sml-mode indentation for structures
Date: Mon, 06 Oct 2014 14:11:28 -0400 [thread overview]
Message-ID: <jwvfvf1kr47.fsf-monnier+gmane.emacs.help@gnu.org> (raw)
In-Reply-To: m2oatpnkrh.fsf@gmail.com
>>>> (add-function :around smie-indent-rules #'my-sml-rules)))
>>> I only had to replace smie-indent-rules with
>>> (symbol-function 'sml-smie-rules).
>> Oh, sorry, it should have been `smie-rules-function'.
>> Using (symbol-function 'sml-smie-rules) instead, ends up being more like
>> the `defadvice' case: it modifies the behavior of sml-mode globally
>> rather than only in the buffer where we run the code.
> I see. Actually I run the code with eval-after-load; but, yes, using
> sml-mode-hook feels cleaner.
BTW: (add-function <foo> (symbol-function <bar>) <toto>) is generally
better written as (advice-add <bar> <foo> <toto>). The difference is
that advice-add will work even if <bar> is not yet defined (i.e. no
need for eval-after-load), and it will work if <bar> is autoloaded, and if
it's a macro, etc...
Stefan
prev parent reply other threads:[~2014-10-06 18:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 9:26 sml-mode indentation for structures Helmut Eller
2014-10-06 12:45 ` Stefan Monnier
[not found] ` <mailman.10564.1412599562.1147.help-gnu-emacs@gnu.org>
2014-10-06 13:34 ` Helmut Eller
2014-10-06 13:59 ` Stefan Monnier
[not found] ` <mailman.10568.1412603979.1147.help-gnu-emacs@gnu.org>
2014-10-06 17:57 ` Helmut Eller
2014-10-06 18:09 ` Helmut Eller
2014-10-06 18:14 ` Stefan Monnier
2014-10-06 18:11 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvfvf1kr47.fsf-monnier+gmane.emacs.help@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.