* Re: [Emacs-diffs] map 35c27cd: Throw an error when converting a map into an unknown map type [not found] ` <E1YjTsd-00037Q-9M@vcs.savannah.gnu.org> @ 2015-04-18 17:47 ` Stefan Monnier 2015-04-18 18:02 ` Nicolas Petton 0 siblings, 1 reply; 2+ messages in thread From: Stefan Monnier @ 2015-04-18 17:47 UTC (permalink / raw To: emacs-devel; +Cc: Nicolas Petton > + (t (error "Not a map type name: %s" type)))) ^^ %S In case the user didn't pass the right argument `type' may be something else than a symbol, so the use of %S makes sure that the error will give a precise description (e.g. if `type' is the string "hash-table", the error message could be surprising). Stefan ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Emacs-diffs] map 35c27cd: Throw an error when converting a map into an unknown map type 2015-04-18 17:47 ` [Emacs-diffs] map 35c27cd: Throw an error when converting a map into an unknown map type Stefan Monnier @ 2015-04-18 18:02 ` Nicolas Petton 0 siblings, 0 replies; 2+ messages in thread From: Nicolas Petton @ 2015-04-18 18:02 UTC (permalink / raw To: Stefan Monnier; +Cc: Nicolas Petton, emacs-devel [-- Attachment #1: Type: text/plain, Size: 561 bytes --] Stefan Monnier writes: >> + (t (error "Not a map type name: %s" type)))) > ^^ > %S > > In case the user didn't pass the right argument `type' may be something > else than a symbol, so the use of %S makes sure that the error will give > a precise description (e.g. if `type' is the string "hash-table", the > error message could be surprising). Oh, thanks! The same is true in seq.el, I'll fix both of them :) Nico -- Nicolas Petton http://nicolas-petton.fr [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 512 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-18 18:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150418143759.11954.68194@vcs.savannah.gnu.org>
[not found] ` <E1YjTsd-00037Q-9M@vcs.savannah.gnu.org>
2015-04-18 17:47 ` [Emacs-diffs] map 35c27cd: Throw an error when converting a map into an unknown map type Stefan Monnier
2015-04-18 18:02 ` Nicolas Petton
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.