From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: etags completion table Date: Sat, 30 May 2015 00:00:35 -0400 Message-ID: References: <555EC552.5010600@swipnet.se> <831ti2yu1a.fsf@gnu.org> <5565E28A.5040507@yandex.ru> <83wpzuxbtd.fsf@gnu.org> <5565E8AB.5020107@yandex.ru> <83r3q2xa3q.fsf@gnu.org> <5566583F.7020503@yandex.ru> <83h9qxxvo4.fsf@gnu.org> <5566EC49.8010907@yandex.ru> <837frsycly.fsf@gnu.org> <5567351E.7020006@yandex.ru> <83zj4owthp.fsf@gnu.org> <5567AE52.1000600@yandex.ru> <83fv6fx0nk.fsf@gnu.org> <55687241.5030200@yandex.ru> <55689E02.5040605@yandex.ru> <5568CD36.2030703@yandex.ru> <5568FD22.4010004@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1432958470 5139 80.91.229.3 (30 May 2015 04:01:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 30 May 2015 04:01:10 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 30 06:01:01 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YyXxE-0004Pw-Cc for ged-emacs-devel@m.gmane.org; Sat, 30 May 2015 06:01:00 +0200 Original-Received: from localhost ([::1]:38251 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyXxD-0004MK-Er for ged-emacs-devel@m.gmane.org; Sat, 30 May 2015 00:00:59 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58631) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyXwv-0004ME-EB for emacs-devel@gnu.org; Sat, 30 May 2015 00:00:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YyXwq-0004Nd-Eh for emacs-devel@gnu.org; Sat, 30 May 2015 00:00:41 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:43408) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyXwq-0004NX-BB for emacs-devel@gnu.org; Sat, 30 May 2015 00:00:36 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AxFgA731xV/3K9xEVcgxCEAoVVu0CHSwQCAoE8OhMBAQEBAQEBgQpBBYNdAQEDAVYjEAsOJhIUGA0kiDcIzyMBAQEHAgEfizqFBQeELQEEsz+BRSOEFCKCeAEBAQ X-IPAS-Result: A0AxFgA731xV/3K9xEVcgxCEAoVVu0CHSwQCAoE8OhMBAQEBAQEBgQpBBYNdAQEDAVYjEAsOJhIUGA0kiDcIzyMBAQEHAgEfizqFBQeELQEEsz+BRSOEFCKCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="123254604" Original-Received: from 69-196-189-114.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([69.196.189.114]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 30 May 2015 00:00:35 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 54918AE0BA; Sat, 30 May 2015 00:00:35 -0400 (EDT) In-Reply-To: <5568FD22.4010004@yandex.ru> (Dmitry Gutov's message of "Sat, 30 May 2015 02:58:26 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:186948 Archived-At: >> I see the first patch says that it takes 1.34s to build the obarray and >> 0.78s to build an equivalent list of strings, so we could change the >> code so as to keep the completion table as a pre-built list of strings >> instead of a pre-built obarray. It will also save us a bit of memory. > Maybe. The difference isn't much, though, and it's a one-time thing. Agreed. But the current use of an obarray is just wrong: it makes the code use more CPU and memory resources for no benefit. Stefan