all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: martin rudalics <rudalics@gmx.at>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 0245cc3: Improve accessibility of window dividers. (Bug#20183)
Date: Thu, 02 Jul 2015 21:50:05 -0400	[thread overview]
Message-ID: <jwvfv56t3sk.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <55957C3A.7020909@gmx.at> (martin rudalics's message of "Thu, 02 Jul 2015 20:00:26 +0200")

> Then I noticed that all items in the Show/Hide group are minor modes.
> Some of them in a contorted sense - both `fringe-mode' and
> `mouse-avoidance-mode' are simple defuns.  I would have preferred to do
> it their style, possibly using completing read.  But I tried to be a
> good citizen and specified `window-divider-mode' in a sense similar to
> `scroll-bar-mode' - the only mode I found that was specified via
> `define-minor-mode' and allowed more than two values.

Indeed, we have problems in there.  Minor modes are designed to be
booleans only.  For after-the-fact situations, we sometimes try to find
a contorted way to consider the feature as a minor mode, even tho it
doesn't quite fit.  But when defining a new feature I think it's
worthwhile to try and design the feature such that it fits.

> But how would a user customize switching from the `right-only' to the
> `bottom-only' state?  How would a user specify the preferred initial
> state?

With the second variable (e.g. could be called `window-divider-places'),
rather than the minor mode variable.


        Stefan



  reply	other threads:[~2015-07-03  1:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150702070503.30720.41171@vcs.savannah.gnu.org>
     [not found] ` <E1ZAYYS-00081G-Fb@vcs.savannah.gnu.org>
2015-07-02 13:55   ` [Emacs-diffs] master 0245cc3: Improve accessibility of window dividers. (Bug#20183) Stefan Monnier
2015-07-02 16:05     ` martin rudalics
2015-07-02 16:28       ` Stefan Monnier
2015-07-02 18:00         ` martin rudalics
2015-07-03  1:50           ` Stefan Monnier [this message]
2015-07-03 13:20             ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvfv56t3sk.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.