all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: fgallina@gnu.org (Fabián Ezequiel Gallina)
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 8867296 2/2: ; python.el: Replace `eval-when-compile` with `eval-and-compile`
Date: Mon, 06 Jul 2015 21:21:30 -0400	[thread overview]
Message-ID: <jwvfv50hine.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <87d204an0e.fsf@gnu.org> ("Fabián Ezequiel Gallina"'s message of "Mon, 06 Jul 2015 20:23:45 -0300")

> Often I would instrument things when debugging and get errors related to
> definitions not available at run-time, which is really annoying, and I
> have to go and eval missing definitions by hand.  This is mainly an
> attempt to leave things in a development friendly state.

OK, that makes sense.  You could leave a short note about it, but it's
probably not worth the trouble.

> Is there any obvious harm in this change?

No, it's just that eval-and-compile is internally a bit more tricky than
eval-when-compile, so I prefer to avoid it when possible (tho the
trickiness doesn't show up when used at top-level, so you're fine here).

And in this case it didn't seem to be needed, so I wondered if there was
some intricate business I was not aware of.


        Stefan



      reply	other threads:[~2015-07-07  1:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150706050244.10112.84425@vcs.savannah.gnu.org>
     [not found] ` <E1ZByYH-0002eD-O7@vcs.savannah.gnu.org>
2015-07-06 13:47   ` [Emacs-diffs] master 8867296 2/2: ; python.el: Replace `eval-when-compile` with `eval-and-compile` Stefan Monnier
2015-07-06 23:23     ` Fabián Ezequiel Gallina
2015-07-07  1:21       ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvfv50hine.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=fgallina@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.