From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#17663: 24.4.50; arc-mode.el has unrar-free hard-coded Date: Wed, 30 Sep 2015 05:51:32 -0400 Message-ID: References: <87ppirel6l.fsf@deyke2.deyke.net> <878u7o9v7d.fsf@petton.fr> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1443680669 25110 80.91.229.3 (1 Oct 2015 06:24:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 1 Oct 2015 06:24:29 +0000 (UTC) Cc: 17663@debbugs.gnu.org To: Nicolas Petton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 01 08:24:17 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZhXHt-000141-6m for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Oct 2015 08:24:17 +0200 Original-Received: from localhost ([::1]:38505 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhXHs-0003tS-FS for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Oct 2015 02:24:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhE3T-0001gy-DQ for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2015 05:52:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZhE3O-00029f-9x for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2015 05:52:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59709) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhE3O-00029b-7K for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2015 05:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZhE3O-000441-2V for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2015 05:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2015 09:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17663 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17663-submit@debbugs.gnu.org id=B17663.144360669615582 (code B ref 17663); Wed, 30 Sep 2015 09:52:02 +0000 Original-Received: (at 17663) by debbugs.gnu.org; 30 Sep 2015 09:51:36 +0000 Original-Received: from localhost ([127.0.0.1]:48680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZhE2x-00043G-Q3 for submit@debbugs.gnu.org; Wed, 30 Sep 2015 05:51:36 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:4956) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZhE2v-000438-Nw for 17663@debbugs.gnu.org; Wed, 30 Sep 2015 05:51:34 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A3EwA731xV/wihxEVcgxBUXoJQhVW7NwmBWoVxBAICgTw5FAEBAQEBAQGBCkEFg10BAQMBViMFCws0EhQYDSQuiAkIDc8WAQEBAQEBAQMBAQEBARkEizqFBQeELQWQNIZtnB6BRSOCChyBbiIxAQGCRQEBAQ X-IPAS-Result: A0A3EwA731xV/wihxEVcgxBUXoJQhVW7NwmBWoVxBAICgTw5FAEBAQEBAQGBCkEFg10BAQMBViMFCws0EhQYDSQuiAkIDc8WAQEBAQEBAQMBAQEBARkEizqFBQeELQWQNIZtnB6BRSOCChyBbiIxAQGCRQEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="166503820" Original-Received: from 69-196-161-8.dsl.teksavvy.com (HELO ceviche.home) ([69.196.161.8]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 30 Sep 2015 05:51:32 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 8B9256624A; Wed, 30 Sep 2015 05:51:32 -0400 (EDT) In-Reply-To: <878u7o9v7d.fsf@petton.fr> (Nicolas Petton's message of "Wed, 30 Sep 2015 10:18:14 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:107090 Archived-At: > I just installed a patch in master to use unar and lsar. Thanks. > My patch removes the use of the "unrar-free" binary completely as 1) it > is no longer available in Fedora, Ubuntu and Debian and 2) According to https://packages.qa.debian.org/u/unrar-free.html, it's available (again) in Debian. > it has been reported not to work properly, but I guess that's up > for discussion. AFAIK it was working OK, except for the fact that it did not handle all compression methods supported by the nonfree "unrar". But since unar works arguably better, it's OK to drop unrar-free, indeed. Stefan PS: Btw, if you're up for some maintenance work on arc-mode.el, there's a real problem to fix in it: opening a large .zip file (for example) can take a *very* long time. This time is spent in set-buffer-multibyte (turning the buffer from unibyte to multibyte) which ends up doing O(N^2) work. We have a workaround for this problem in auto-coding-alist where we arrange for those binary files to be loaded directly into a multibyte buffer (thanks to the no-conversion-multibyte coding-system), thus avoiding the nasty O(N^2) problem. But a better solution would be to do what we do in tar-mode.el: rather than keep the archive's binary data and its user-displayed listing both in the same buffer, we use two different buffers: a unibyte one containing the binary data, and a multibyte one displaying the contents.