From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Nicolas Petton <nicolas@petton.fr>
Cc: 17663@debbugs.gnu.org
Subject: bug#17663: 24.4.50; arc-mode.el has unrar-free hard-coded
Date: Wed, 30 Sep 2015 05:51:32 -0400 [thread overview]
Message-ID: <jwvfv1wcl3n.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <878u7o9v7d.fsf@petton.fr> (Nicolas Petton's message of "Wed, 30 Sep 2015 10:18:14 +0200")
> I just installed a patch in master to use unar and lsar.
Thanks.
> My patch removes the use of the "unrar-free" binary completely as 1) it
> is no longer available in Fedora, Ubuntu and Debian and 2)
According to https://packages.qa.debian.org/u/unrar-free.html,
it's available (again) in Debian.
> it has been reported not to work properly, but I guess that's up
> for discussion.
AFAIK it was working OK, except for the fact that it did not handle all
compression methods supported by the nonfree "unrar".
But since unar works arguably better, it's OK to drop
unrar-free, indeed.
Stefan
PS: Btw, if you're up for some maintenance work on arc-mode.el, there's
a real problem to fix in it: opening a large .zip file (for example) can
take a *very* long time. This time is spent in set-buffer-multibyte
(turning the buffer from unibyte to multibyte) which ends up doing
O(N^2) work. We have a workaround for this problem in auto-coding-alist
where we arrange for those binary files to be loaded directly into
a multibyte buffer (thanks to the no-conversion-multibyte
coding-system), thus avoiding the nasty O(N^2) problem. But a better
solution would be to do what we do in tar-mode.el: rather than keep the
archive's binary data and its user-displayed listing both in the same
buffer, we use two different buffers: a unibyte one containing the
binary data, and a multibyte one displaying the contents.
next prev parent reply other threads:[~2015-09-30 9:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 9:05 bug#17663: 24.4.50; arc-mode.el has unrar-free hard-coded Dieter Deyke
2014-06-02 14:12 ` Stefan Monnier
2014-06-02 14:40 ` Dieter Deyke
2015-09-30 8:18 ` Nicolas Petton
2015-09-30 8:20 ` Nicolas Petton
2015-09-30 9:51 ` Stefan Monnier [this message]
2015-09-30 10:16 ` Eli Zaretskii
2015-09-30 12:06 ` Nicolas Petton
2015-09-30 13:56 ` Eli Zaretskii
2015-10-05 11:19 ` Nicolas Petton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvfv1wcl3n.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=17663@debbugs.gnu.org \
--cc=nicolas@petton.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.