From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master acfb5cd: Improve XEmacs compatibility of Tramp Date: Sun, 04 Oct 2015 21:06:14 -0400 Message-ID: References: <20151004110041.8886.52525@vcs.savannah.gnu.org> <87si5qsdsx.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1444007205 29345 80.91.229.3 (5 Oct 2015 01:06:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 5 Oct 2015 01:06:45 +0000 (UTC) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 05 03:06:36 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZiuEd-0006bA-IA for ged-emacs-devel@m.gmane.org; Mon, 05 Oct 2015 03:06:35 +0200 Original-Received: from localhost ([::1]:43977 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZiuEc-0003vQ-Lf for ged-emacs-devel@m.gmane.org; Sun, 04 Oct 2015 21:06:34 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36064) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZiuEO-0003up-Qg for emacs-devel@gnu.org; Sun, 04 Oct 2015 21:06:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZiuEJ-00080u-Qf for emacs-devel@gnu.org; Sun, 04 Oct 2015 21:06:20 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:2378) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZiuEJ-00080m-M2 for emacs-devel@gnu.org; Sun, 04 Oct 2015 21:06:15 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0ArEwA731xV/3aQs2tcgxCEAoVVuzcJh0sEAgKBPDkUAQEBAQEBAYEKQQWDXQEBBFYjEAs0EhQYDSSIP88jAQEBAQYCAR+LOoUFB4QtBbUEI4QUIoJ4AQEB X-IPAS-Result: A0ArEwA731xV/3aQs2tcgxCEAoVVuzcJh0sEAgKBPDkUAQEBAQEBAYEKQQWDXQEBBFYjEAs0EhQYDSSIP88jAQEBAQYCAR+LOoUFB4QtBbUEI4QUIoJ4AQEB X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="167449051" Original-Received: from 107-179-144-118.cpe.teksavvy.com (HELO pastel.home) ([107.179.144.118]) by ironport2-out.teksavvy.com with ESMTP; 04 Oct 2015 21:06:15 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 7E2AB61772; Sun, 4 Oct 2015 21:06:14 -0400 (EDT) In-Reply-To: <87si5qsdsx.fsf@gmx.de> (Michael Albinus's message of "Sun, 04 Oct 2015 20:12:46 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:190915 Archived-At: >>> + ;; `directory-listing-before-filename-regexp' does not exist in >>> + ;; XEmacs. Since we use it only in tramp-adb.el, it doesn't harm to >>> + ;; declare it here. >>> + (unless (boundp 'directory-listing-before-filename-regexp) >>> + (defvar directory-listing-before-filename-regexp nil)) >> Why not do >> (defvar directory-listing-before-filename-regexp) >> at top-level, which AFAIK works in all emacsen and is less harmful? > I've tried this first. XEmacs denies to cooperate. In which sense does it deny to cooperate? [ You do need to put the declaration in the file where it's used (rather than in tramp-compat.el), of course. ] Stefan