From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] comment-cache 223d16f 2/3: Apply `comment-depth' text properties when calling `back_comment'. Date: Mon, 14 Mar 2016 23:14:45 -0400 Message-ID: References: <20160308183010.GB6269@acm.fritz.box> <20160309174816.GE3948@acm.fritz.box> <56E0805F.3050804@gmx.at> <20160312170839.GE2572@acm.fritz.box> <20160312215839.GC10781@acm.fritz.box> <20160313175922.GE1871@acm.fritz.box> <20160314125137.GD1894@acm.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1458011703 24195 80.91.229.3 (15 Mar 2016 03:15:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 15 Mar 2016 03:15:03 +0000 (UTC) Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 15 04:14:55 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1affRe-0008Be-SV for ged-emacs-devel@m.gmane.org; Tue, 15 Mar 2016 04:14:55 +0100 Original-Received: from localhost ([::1]:45156 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1affRe-0001VP-1S for ged-emacs-devel@m.gmane.org; Mon, 14 Mar 2016 23:14:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1affRb-0001UO-6d for emacs-devel@gnu.org; Mon, 14 Mar 2016 23:14:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1affRX-0001Xq-6R for emacs-devel@gnu.org; Mon, 14 Mar 2016 23:14:51 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:19376) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1affRX-0001Xi-21 for emacs-devel@gnu.org; Mon, 14 Mar 2016 23:14:47 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CdDQA731xV/wr0d0tcgxCEAshgBAICgTw9EAEBAQEBAQGBCkEFg10BAQMBViMFCwsOJgcLFBgNJIg3CM8jAQEBAQYBAQEBHos6hQUHhC0FkDSaR4hEgUUjgjuBWSKCeAEBAQ X-IPAS-Result: A0CdDQA731xV/wr0d0tcgxCEAshgBAICgTw9EAEBAQEBAQGBCkEFg10BAQMBViMFCwsOJgcLFBgNJIg3CM8jAQEBAQYBAQEBHos6hQUHhC0FkDSaR4hEgUUjgjuBWSKCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="196231289" Original-Received: from 75-119-244-10.dsl.teksavvy.com (HELO ceviche.home) ([75.119.244.10]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 14 Mar 2016 23:14:45 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 4762A661AA; Mon, 14 Mar 2016 23:14:45 -0400 (EDT) In-Reply-To: <20160314125137.GD1894@acm.fritz.box> (Alan Mackenzie's message of "Mon, 14 Mar 2016 12:51:37 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201774 > I've just timed this over xdisp.c. A parse-partial-sexp from > (point-min) to (point-max) took 0.031s. A further scan, applying the > `literal-cache' properties, took 0.054s. That's 0.023s on a 1 MByte > buffer. That's not too serious. Agreed. > syntax-ppss throws away a lot more information that comment-cache does - > it retains a parse state only every 20,000 characters, discarding > everything else between those points. That was just the original choice. As discussed, this could be easily changed if/when needed. So far it's proved perfectly adequate. Stefan