From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 269d563: Support completion of attribute values in CSS mode Date: Thu, 24 Mar 2016 10:31:25 -0400 Message-ID: References: <20160323180952.31942.96525@vcs.savannah.gnu.org> <1458828752.7618.0@smtp.gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1458829911 27910 80.91.229.3 (24 Mar 2016 14:31:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Mar 2016 14:31:51 +0000 (UTC) Cc: Dmitry Gutov , emacs-devel@gnu.org To: Simen =?windows-1252?Q?Heggest=F8yl?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 24 15:31:41 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aj6IT-0001Te-Nh for ged-emacs-devel@m.gmane.org; Thu, 24 Mar 2016 15:31:37 +0100 Original-Received: from localhost ([::1]:50706 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj6IS-0003Pc-Vp for ged-emacs-devel@m.gmane.org; Thu, 24 Mar 2016 10:31:37 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51169) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj6IN-0003MQ-V1 for emacs-devel@gnu.org; Thu, 24 Mar 2016 10:31:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aj6IK-0008Bn-8l for emacs-devel@gnu.org; Thu, 24 Mar 2016 10:31:31 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:21828) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj6IK-0008BD-4W for emacs-devel@gnu.org; Thu, 24 Mar 2016 10:31:28 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AxFgA731xV/5a2xEVcgxCEAoVVu0CHSwQCAoE8OxIBAQEBAQEBgQpBBYNdAQEDAVYjBQsLNBIUGA0kiDcIzyMBAQEBBgEBAQEeizqELVgHhC0FhQmWW5dbgUUjYYFagVkigTWBQwEBAQ X-IPAS-Result: A0AxFgA731xV/5a2xEVcgxCEAoVVu0CHSwQCAoE8OxIBAQEBAQEBgQpBBYNdAQEDAVYjBQsLNBIUGA0kiDcIzyMBAQEBBgEBAQEeizqELVgHhC0FhQmWW5dbgUUjYYFagVkigTWBQwEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="198302157" Original-Received: from 69-196-182-150.dsl.teksavvy.com (HELO pastel.home) ([69.196.182.150]) by ironport2-out.teksavvy.com with ESMTP; 24 Mar 2016 10:31:26 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 6011462384; Thu, 24 Mar 2016 10:31:25 -0400 (EDT) In-Reply-To: <1458828752.7618.0@smtp.gmail.com> ("Simen =?windows-1252?Q?H?= =?windows-1252?Q?eggest=F8yl=22's?= message of "Thu, 24 Mar 2016 15:12:32 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:202174 Archived-At: >> Does that now fully make company-css obsolete (well, obviously only for >> those users that use the bleeding edge version of Emacs)? Or are there >> still some functionality that hasn't yet been ported? > It depends on whether we want to support completion of HTML tags in > selectors, that's the last remaining functionality that hasn't been > ported I think. > Personally I don't find much value in it, since I mostly use class names > in selectors, and the HTML tags I do use are short and easy to type. But > if others find it useful I can port it. The important part, for me, is to try and make sure we can declare company-css obsolete. In theory, at least, completion of HTML tags in selectors makes sense to me, but I'd hope we can do it without hardcoding the list of tags in css-mode.el (e.g. using html-tag-alist from sgml-mode.el, or using nxml). BTW, even better (for me) would be to make the completion pay attention to existing html buffers, so you can limit the completion to those tags actually relevant (and you can additionally provide completion of user-chosen classes). Stefan