From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: nljlistbox2@gmail.com, npostavs@users.sourceforge.net,
jwiegley@gmail.com, rpluim@gmail.com, 23917@debbugs.gnu.org,
alex.bennee@linaro.org
Subject: bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks)
Date: Wed, 20 Jul 2016 14:19:59 -0400 [thread overview]
Message-ID: <jwvfur4ch16.fsf-monnier+emacsbugs__45859.7900149927$1469041000$gmane$org@gnu.org> (raw)
In-Reply-To: <83shv4z7e8.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 20 Jul 2016 17:55:11 +0300")
> Is it OK to adjust the match data before actually making the
> replacement? If so, I think it's a simpler solution.
>> PS: I can think of one (theoretical) other/better way to fix this
>> problem: move the match-data adjustment so it's done within
>> replace_range before running the after-change-functions.
> Isn't that almost the same as what Noam suggested?
Yes, it's the same. And yes, I like the idea, but I just don't know
what it would look like as a patch. I have the impression that it could
prove either expensive in CPU time and backward incompatible
(e.g. adjust markers for every buffer modification), or require
extensive code surgery and/or breaking some abstractions.
This is just an impression, tho. I think it'd definitely be the better
solution, so it's worth investigating anyway, if only for "master" rather
than for "emacs-25".
Stefan
next prev parent reply other threads:[~2016-07-20 18:19 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 16:39 org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks Alex Bennée
2016-07-15 17:39 ` Eli Zaretskii
2016-07-15 19:12 ` Alex Bennée
2016-07-15 19:37 ` Noam Postavsky
2016-07-15 21:56 ` Alex Bennée
2016-07-16 16:01 ` Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks) N. Jackson
2016-07-16 16:11 ` Eli Zaretskii
2016-07-16 17:09 ` John Wiegley
2016-07-17 17:28 ` Alex Bennée
2016-07-17 17:41 ` Eli Zaretskii
2016-07-18 12:24 ` bug#23917: " Robert Pluim
2016-07-18 18:09 ` Eli Zaretskii
2016-07-18 19:04 ` John Wiegley
2016-07-18 19:10 ` Eli Zaretskii
2016-07-18 19:10 ` Eli Zaretskii
2016-07-18 19:04 ` John Wiegley
2016-07-19 0:58 ` Stefan Monnier
2016-07-19 2:40 ` Eli Zaretskii
2016-07-19 4:48 ` Stefan Monnier
2016-07-19 15:35 ` Eli Zaretskii
2016-07-19 15:35 ` Eli Zaretskii
2016-07-19 16:03 ` Stefan Monnier
2016-07-19 16:13 ` Eli Zaretskii
2016-07-19 17:05 ` bug#23917: [O] " Alex Bennée
2016-07-19 17:20 ` Eli Zaretskii
2016-07-19 17:45 ` bug#23917: " Alex Bennée
2016-07-19 17:45 ` bug#23917: [O] " Alex Bennée
2016-07-19 18:07 ` Sebastian Wiesner
2016-07-19 18:07 ` bug#23917: " Sebastian Wiesner
2016-07-19 18:44 ` bug#23917: [O] " Eli Zaretskii
2016-07-19 18:44 ` bug#23917: " Eli Zaretskii
2016-07-20 9:48 ` bug#23917: [O] " Alex Bennée
2016-07-20 14:59 ` Eli Zaretskii
2016-07-20 14:59 ` bug#23917: " Eli Zaretskii
2016-07-20 9:48 ` Alex Bennée
2016-07-19 17:20 ` Eli Zaretskii
2016-07-19 17:05 ` Alex Bennée
2016-07-20 1:50 ` Stefan Monnier
2016-07-20 1:50 ` Stefan Monnier
2016-07-20 14:55 ` Eli Zaretskii
2016-07-20 14:55 ` Eli Zaretskii
2016-07-20 18:19 ` Stefan Monnier
2016-07-20 18:55 ` Eli Zaretskii
2016-07-20 20:54 ` Stefan Monnier
2016-07-20 20:54 ` Stefan Monnier
2016-07-21 0:56 ` npostavs
2016-07-21 0:56 ` npostavs
2016-07-21 1:47 ` Stefan Monnier
2016-07-21 1:47 ` Stefan Monnier
2016-07-21 2:34 ` Noam Postavsky
2016-07-21 3:06 ` Stefan Monnier
2016-07-21 3:06 ` Stefan Monnier
2016-07-21 2:34 ` Noam Postavsky
2016-07-21 2:43 ` Eli Zaretskii
2016-07-21 3:00 ` npostavs
2016-07-21 3:00 ` npostavs
2016-07-21 14:26 ` Eli Zaretskii
2016-07-21 14:26 ` Eli Zaretskii
2016-07-22 1:08 ` npostavs
2016-07-22 6:43 ` Eli Zaretskii
2016-07-22 14:01 ` Robert Pluim
2016-07-22 14:01 ` Robert Pluim
2016-07-22 19:30 ` Nicolas Petton
2016-07-22 19:30 ` Nicolas Petton
2016-07-23 4:19 ` npostavs
2016-07-23 4:19 ` npostavs
2016-07-22 6:43 ` Eli Zaretskii
2016-07-23 0:42 ` bug#23917: Re: bug#23917: 25.0.95; commit 3a9d6296b35e5317c497674d5725eb52699bd3b8 causing org-capture to error out N. Jackson
2016-07-23 7:38 ` Eli Zaretskii
2016-07-23 7:38 ` Eli Zaretskii
2016-07-23 0:42 ` bug#23917: " N. Jackson
2016-07-22 1:08 ` bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks) npostavs
2016-07-21 2:43 ` Eli Zaretskii
2016-07-21 7:59 ` bug#23917: 25.0.95; commit 3a9d6296b35e5317c497674d5725eb52699bd3b8 causing org-capture to error out N. Jackson
2016-07-21 8:19 ` Robert Pluim
2016-07-21 8:19 ` Robert Pluim
2016-07-08 12:42 ` Robert Pluim
2016-07-08 14:02 ` Eli Zaretskii
2016-07-08 15:40 ` Robert Pluim
2016-07-08 17:03 ` Eli Zaretskii
2016-07-08 17:03 ` Eli Zaretskii
2016-07-15 19:46 ` Eli Zaretskii
2016-07-15 19:46 ` Eli Zaretskii
2016-07-21 14:24 ` N. Jackson
2016-07-21 14:24 ` N. Jackson
2016-07-21 7:59 ` N. Jackson
2016-07-20 18:55 ` bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks) Eli Zaretskii
2016-07-20 18:19 ` Stefan Monnier [this message]
2016-07-19 16:13 ` Eli Zaretskii
2016-07-19 16:03 ` Stefan Monnier
2016-07-19 23:18 ` npostavs
2016-07-19 23:18 ` npostavs
2016-07-19 4:48 ` Stefan Monnier
2016-07-19 2:40 ` Eli Zaretskii
2016-07-19 15:36 ` Eli Zaretskii
2016-07-19 15:36 ` Eli Zaretskii
2016-07-19 0:58 ` Stefan Monnier
2016-07-21 7:52 ` bug#23917: 25.0.95; commit 3a9d6296b35e5317c497674d5725eb52699bd3b8 causing org-capture to error out N. Jackson
2016-07-21 8:08 ` Robert Pluim
2016-07-21 8:08 ` Robert Pluim
2016-07-21 13:19 ` N. Jackson
2016-07-21 13:19 ` N. Jackson
2016-07-21 7:52 ` N. Jackson
2016-07-18 18:09 ` bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template ‘g’: Match data clobbered by buffer modification hooks) Eli Zaretskii
2016-07-18 12:24 ` Robert Pluim
2016-07-18 14:50 ` Kaushal Modi
2016-07-18 14:50 ` Kaushal Modi
[not found] ` <9613abde4dbd48fdb2b5e780101a13a0@HE1PR01MB1898.eurprd01.prod.exchangelabs.com>
2016-07-18 16:59 ` Eric S Fraga
2016-07-18 16:59 ` Eric S Fraga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='jwvfur4ch16.fsf-monnier+emacsbugs__45859.7900149927$1469041000$gmane$org@gnu.org' \
--to=monnier@iro.umontreal.ca \
--cc=23917@debbugs.gnu.org \
--cc=alex.bennee@linaro.org \
--cc=eliz@gnu.org \
--cc=jwiegley@gmail.com \
--cc=nljlistbox2@gmail.com \
--cc=npostavs@users.sourceforge.net \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.