From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Tom Tromey <tom@tromey.com>
Cc: 25529@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#25529: diagnosis and one approach to a fix
Date: Fri, 10 Feb 2017 22:45:54 -0500 [thread overview]
Message-ID: <jwvfujlv1e1.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87vash5wag.fsf@tromey.com> (Tom Tromey's message of "Fri, 10 Feb 2017 18:52:07 -0700")
> -(defun js-syntax-propertize-regexp (end)
> +(defun js-syntax-propertize-regexp ()
Removing the `end` argument is fundamentally wrong. It's OK to play it
fast-and-loose and ignore that argument, but the function *should* keep
the buffer untouched after `end`.
> + (put-text-property (match-beginning 1) (match-end 1)
^^^^^^^^^^^^^
(min end (match-end 1))
should do it.
Stefan
next prev parent reply other threads:[~2017-02-11 3:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 7:22 bug#25529: 25.1.90; js-mode: Regexp literal with unbalanced brackets breaks font-lock Mikhail Gusarov
2017-02-05 5:37 ` bug#25529: diagnosis and one approach to a fix Tom Tromey
2017-02-05 6:01 ` Tom Tromey
2017-02-05 18:05 ` Tom Tromey
2017-02-05 18:43 ` Tom Tromey
2017-02-06 1:12 ` Dmitry Gutov
2017-02-06 17:27 ` Tom Tromey
2017-02-07 2:20 ` Dmitry Gutov
2017-02-07 13:07 ` Tom Tromey
2017-02-07 13:11 ` Dmitry Gutov
2017-02-07 14:56 ` Stefan Monnier
2017-02-11 1:52 ` Tom Tromey
2017-02-11 3:45 ` Stefan Monnier [this message]
2017-02-11 4:06 ` Tom Tromey
2017-02-11 4:22 ` Stefan Monnier
2017-02-11 15:27 ` Tom Tromey
2017-02-11 15:41 ` Stefan Monnier
2017-02-11 17:13 ` Tom Tromey
2017-02-11 19:11 ` Dmitry Gutov
2017-02-11 19:37 ` bug#25529: done Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvfujlv1e1.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=25529@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.