all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: [PATCH] unsafep: Add support for (funcall)
Date: Tue, 28 Feb 2017 11:18:51 -0500	[thread overview]
Message-ID: <jwvfuiy2stl.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: CA+T2Sh1Wq26e+RcMKoLRrPrqFf2szFE_7wh56AdfEYBVsNAUXw@mail.gmail.com

>> Hmm... I don't quite get it:
>> 
>> (funcall '<sym> ...)
>> 
>> is better written as
>> 
>> (<sym> ...)
>> 
>> so why/when do you see such code?  Could we rewrite it before unsafep
>> gets to look at it.

> Indeed, byte-compile-funcall rewrites such forms. I've just added this
> to remove a potential false positive from unsafep, as it's not only
> the byte compiler and optimizer that use it (for instance, ses.el uses
> it to warn the user about "unsafe" formulae).

But unsafep must call something like macroexpand-all or something like
that, so we could (should?) arrange for that to do the rewrite.


        Stefan




      reply	other threads:[~2017-02-28 16:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-27 18:53 [PATCH] unsafep: Add support for (funcall) Vibhav Pant
2017-02-27 20:56 ` Stefan Monnier
2017-02-28 15:40   ` Vibhav Pant
2017-02-28 16:18     ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvfuiy2stl.fsf-monnier+gmane.emacs.devel@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.