From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Smie-auto-fill =?utf-8?Q?doesn=E2=80=99t?= respect comment-auto-fill-only-comments Date: Mon, 22 May 2017 15:12:15 -0400 Message-ID: References: <87o9vdj0s5.fsf@tromey.com> <87mvavw0h5.fsf@pokyo> <87r2zidut2.fsf@bapiya> <87d1b1e7e3.fsf@bapiya> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1495480362 25606 195.159.176.226 (22 May 2017 19:12:42 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 22 May 2017 19:12:42 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 22 21:12:37 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCskt-0006Mz-Oz for ged-emacs-devel@m.gmane.org; Mon, 22 May 2017 21:12:35 +0200 Original-Received: from localhost ([::1]:44466 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCskw-0006dD-40 for ged-emacs-devel@m.gmane.org; Mon, 22 May 2017 15:12:38 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCskp-0006a2-Uw for emacs-devel@gnu.org; Mon, 22 May 2017 15:12:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dCskk-0008Qp-WE for emacs-devel@gnu.org; Mon, 22 May 2017 15:12:31 -0400 Original-Received: from [195.159.176.226] (port=53501 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dCskk-0008QU-QH for emacs-devel@gnu.org; Mon, 22 May 2017 15:12:26 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dCska-00060d-3r for emacs-devel@gnu.org; Mon, 22 May 2017 21:12:16 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 20 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:0yaf4DQpxzEBg5LFeoR3NGGP5SE= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:215101 Archived-At: > (let (compos comin) > - ;; If we are not inside a comment and we only auto-fill comments, > - ;; don't do anything (unless no comment syntax is defined). > + ;; If we are not inside a comment don't do anything (unless no > + ;; comment syntax is defined). > (unless (and comment-start > - comment-auto-fill-only-comments > (not (called-interactively-p 'interactive)) > (not (save-excursion > (prog1 (setq compos (comment-beginning)) I think we want to remove the whole test: this `unless` is there specifically in order to do nothing if we're outside of comments and comment-auto-fill-only-comments is non-nil. But now the "comment-auto-fill-only-comments is non-nil" case is already handled outside, so we can just always do the auto-fill as if comment-auto-fill-only-comments were nil. Stefan