* Re: [elpa] externals/ebdb 4206ccd 02/21: Don't unilaterally add to kill-emacs-hook
[not found] ` <20170917193245.721F520AB5@vcs0.savannah.gnu.org>
@ 2017-09-17 20:56 ` Stefan Monnier
2017-09-17 21:37 ` Eric Abrahamsen
2017-09-17 21:40 ` Eric Abrahamsen
0 siblings, 2 replies; 5+ messages in thread
From: Stefan Monnier @ 2017-09-17 20:56 UTC (permalink / raw)
To: emacs-devel; +Cc: Eric Abrahamsen
> +(defcustom ebdb-install-save-hook t
> + "If non-nil, add `ebdb-save' to the hook `kill-emacs-hook'."
> + :group 'ebdb-eieio
> + :type 'boolean)
I think the docstring should talk about the intended effect from the
user's point of view, rather than from the implementation's point
of view. I'm not 100% sure what is the intended effect, but it seems to
be something like "automatically save EBDB when leaving Emacs".
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [elpa] externals/ebdb 4206ccd 02/21: Don't unilaterally add to kill-emacs-hook
2017-09-17 20:56 ` [elpa] externals/ebdb 4206ccd 02/21: Don't unilaterally add to kill-emacs-hook Stefan Monnier
@ 2017-09-17 21:37 ` Eric Abrahamsen
2017-09-17 21:40 ` Eric Abrahamsen
1 sibling, 0 replies; 5+ messages in thread
From: Eric Abrahamsen @ 2017-09-17 21:37 UTC (permalink / raw)
To: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> +(defcustom ebdb-install-save-hook t
>> + "If non-nil, add `ebdb-save' to the hook `kill-emacs-hook'."
>> + :group 'ebdb-eieio
>> + :type 'boolean)
>
> I think the docstring should talk about the intended effect from the
> user's point of view, rather than from the implementation's point
> of view. I'm not 100% sure what is the intended effect, but it seems to
> be something like "automatically save EBDB when leaving Emacs".
Yes, that's the intended effect. I'd originally had the `add-hook' at
top level in ebdb-com.el, so loading the file added the hook. That led
to `ebdb-save' being called when batch compiling and testing (ugh). I'll
re-work the docstring.
Thanks,
Eric
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [elpa] externals/ebdb 4206ccd 02/21: Don't unilaterally add to kill-emacs-hook
2017-09-17 20:56 ` [elpa] externals/ebdb 4206ccd 02/21: Don't unilaterally add to kill-emacs-hook Stefan Monnier
2017-09-17 21:37 ` Eric Abrahamsen
@ 2017-09-17 21:40 ` Eric Abrahamsen
1 sibling, 0 replies; 5+ messages in thread
From: Eric Abrahamsen @ 2017-09-17 21:40 UTC (permalink / raw)
To: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> +(defcustom ebdb-install-save-hook t
>> + "If non-nil, add `ebdb-save' to the hook `kill-emacs-hook'."
>> + :group 'ebdb-eieio
>> + :type 'boolean)
>
> I think the docstring should talk about the intended effect from the
> user's point of view, rather than from the implementation's point
> of view. I'm not 100% sure what is the intended effect, but it seems to
> be something like "automatically save EBDB when leaving Emacs".
Actually, thinking in those terms, the option is poorly named, as well.
^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20170917193248.D117F20AB5@vcs0.savannah.gnu.org>]
end of thread, other threads:[~2017-09-17 21:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170917193244.24537.24926@vcs0.savannah.gnu.org>
[not found] ` <20170917193245.721F520AB5@vcs0.savannah.gnu.org>
2017-09-17 20:56 ` [elpa] externals/ebdb 4206ccd 02/21: Don't unilaterally add to kill-emacs-hook Stefan Monnier
2017-09-17 21:37 ` Eric Abrahamsen
2017-09-17 21:40 ` Eric Abrahamsen
[not found] ` <20170917193248.D117F20AB5@vcs0.savannah.gnu.org>
2017-09-17 20:59 ` [elpa] externals/ebdb 2b52686 18/21: Check type spec of slots that may or may not accept an object Stefan Monnier
2017-09-17 21:34 ` Eric Abrahamsen
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.