all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: 28587@debbugs.gnu.org
Subject: bug#28587: 26.0.60; Don't write object name strings in object-write method
Date: Wed, 08 Nov 2017 15:31:07 -0500	[thread overview]
Message-ID: <jwvfu9o5xdr.fsf-monnier+Inbox@gnu.org> (raw)
In-Reply-To: <87o9octu8m.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Wed, 08 Nov 2017 12:01:45 -0800")

> So where we're at now is, the previous chunk has gone into both master
> and emacs-26.

Yay!

> The next patch (below) would only go into master, so as to
> be more conservative about what's emitted. Everything defaults to
> current behavior.

Looks good, except for:

> +  "When non-nil write the object name in `object-write'.
> +Does not affect objects subclassing `eieio-named'.  Writing
> +object names is deprecated as of Emacs 24.4; consider setting
> +this to nil.")

AFAIK names are deprecated in calls to EIEIO constructors since
Emacs-25 (rather 24.4), and it's only since Emacs-26 that they are
optional in "eieio-presistent" written representations.


        Stefan





  reply	other threads:[~2017-11-08 20:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-24 21:11 bug#28587: 26.0.60; Don't write object name strings in object-write method Eric Abrahamsen
2017-10-22  3:29 ` Stefan Monnier
2017-11-08 20:01   ` Eric Abrahamsen
2017-11-08 20:31     ` Stefan Monnier [this message]
2017-11-08 21:01       ` Eric Abrahamsen
2017-11-08 22:05         ` Stefan Monnier
2017-11-08 22:08           ` Eric Abrahamsen
2017-11-11  1:39           ` Eric Abrahamsen
2017-11-22 22:30           ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvfu9o5xdr.fsf-monnier+Inbox@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=28587@debbugs.gnu.org \
    --cc=eric@ericabrahamsen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.