From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.help Subject: Re: minor-mode hook not run Date: Thu, 22 Mar 2018 09:52:00 -0400 Message-ID: References: <2c3c91da-0f8e-cad2-1746-b3f7a66da98d@easy-emacs.de> <83fcbe37-e20f-a79c-bc00-01ff5c31225d@easy-emacs.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1521726646 17362 195.159.176.226 (22 Mar 2018 13:50:46 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 22 Mar 2018 13:50:46 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Thu Mar 22 14:50:42 2018 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ez0c1-0004IT-Nz for geh-help-gnu-emacs@m.gmane.org; Thu, 22 Mar 2018 14:50:37 +0100 Original-Received: from localhost ([::1]:60925 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ez0e5-0006Yg-4x for geh-help-gnu-emacs@m.gmane.org; Thu, 22 Mar 2018 09:52:45 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ez0db-0006Xw-Mj for help-gnu-emacs@gnu.org; Thu, 22 Mar 2018 09:52:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ez0dV-0004zq-Pm for help-gnu-emacs@gnu.org; Thu, 22 Mar 2018 09:52:15 -0400 Original-Received: from [195.159.176.226] (port=36656 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ez0dV-0004yY-I2 for help-gnu-emacs@gnu.org; Thu, 22 Mar 2018 09:52:09 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1ez0bQ-0003Uc-2H for help-gnu-emacs@gnu.org; Thu, 22 Mar 2018 14:50:00 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 39 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:tZF+nL6RkXbuKeNhOvaH48tqUp8= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.org gmane.emacs.help:116260 Archived-At: >>> (add-hook 'foo-mode-hook 'foo-load-abc nil t) >> Adding elements to one's own hook here definitely deserve a "bug ugly >> hack" comment explaining why you'd want to do it that way. > Hmm, not sure if I understand that part. I'm saying that adding to -mode-hook from within the body of -mode is weird. Instead of (define-minor-mode foo-mode ... (add-hook 'foo-mode-hook #'blabla nil t) ...) why not do the more natural: (define-minor-mode foo-mode ... (blabla) ...) The "big ugly hack" comment should explain why the `add-hook` version is needed. > Purpose is a generic key for related commands: > For example to start a REPL, haskell-mode calls > ‘haskell-interactive-switch’, python.el calls ‘run-python’, > python-mode.el ‘py-shell’ etc. > > Instead of remembering different keys and change them maybe at several > locations, a unified command ‘gk-repl’ is provided, whose key-binding > should DTRT in all modes. I don't see how this explains why you need to go through foo-mode-hook rather than calling the function directly. Stefan