From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14529: gv--defsetter, advice--set-buffer-local compilation warnings Date: Fri, 23 Mar 2018 19:25:01 -0400 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1521847456 10966 195.159.176.226 (23 Mar 2018 23:24:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 23 Mar 2018 23:24:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 14529@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 24 00:24:12 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezW2Y-0002ca-QD for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Mar 2018 00:24:06 +0100 Original-Received: from localhost ([::1]:40306 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezW4a-000088-5u for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Mar 2018 19:26:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51123) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezW4U-00007r-2T for bug-gnu-emacs@gnu.org; Fri, 23 Mar 2018 19:26:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezW4P-0001A0-Vv for bug-gnu-emacs@gnu.org; Fri, 23 Mar 2018 19:26:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42255) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ezW4P-00019s-Ry for bug-gnu-emacs@gnu.org; Fri, 23 Mar 2018 19:26:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ezW4P-00075R-IO for bug-gnu-emacs@gnu.org; Fri, 23 Mar 2018 19:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Mar 2018 23:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14529 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14529-submit@debbugs.gnu.org id=B14529.152184750627160 (code B ref 14529); Fri, 23 Mar 2018 23:26:01 +0000 Original-Received: (at 14529) by debbugs.gnu.org; 23 Mar 2018 23:25:06 +0000 Original-Received: from localhost ([127.0.0.1]:50152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezW3W-000740-5Z for submit@debbugs.gnu.org; Fri, 23 Mar 2018 19:25:06 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:38202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezW3U-00073s-35 for 14529@debbugs.gnu.org; Fri, 23 Mar 2018 19:25:05 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w2NNP2iT031702; Fri, 23 Mar 2018 19:25:02 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 1363866480; Fri, 23 Mar 2018 19:25:02 -0400 (EDT) In-Reply-To: (Glenn Morris's message of "Fri, 23 Mar 2018 17:16:40 -0400") X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 3 Rules triggered AFF_LOTTO_1=0.2, EDT_SA_DN_PASS=0, RV6249=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6249> : inlines <6517> : streams <1782072> : uri <2613646> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144571 Archived-At: Glenn Morris writes: > Stefan Monnier wrote: > >>> the function `gv--defsetter' might not be defined at runtime. >>> (image-mode, winner, avl-tree [] >> >> gv--setter is used inside a function placed on the `gv-expander' >> property of some symbols, which should never be used except by gv.el >> code (at which point gv--defsetter will be defined). > > These warnings have come back following 97b7e58. > Obviously they can be declare-functioned away, but it would be nicer if > there was a general solution that did not require modifying each file > that declares a gv-setter. I'd love to have a general way to say things like "code on symbol property `gv-expand' can use any function provided by gv.el", but in the mean time would the patch below work? Stefan diff --git a/lisp/emacs-lisp/gv.el b/lisp/emacs-lisp/gv.el index 1e5347d206..230d59f189 100644 --- a/lisp/emacs-lisp/gv.el +++ b/lisp/emacs-lisp/gv.el @@ -216,6 +216,8 @@ gv-define-setter (declare (indent 2) (debug (&define name sexp body))) `(gv-define-expander ,name (lambda (do &rest args) + (declare-function + gv--defsetter "gv" (name setter do args &optional vars)) (gv--defsetter ',name (lambda ,arglist ,@body) do args)))) ;;;###autoload