all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: 30190@debbugs.gnu.org, Noam Postavsky <npostavs@gmail.com>
Subject: bug#30190: 27.0.50; term run in line mode shows user passwords
Date: Thu, 21 Jun 2018 15:17:19 -0400	[thread overview]
Message-ID: <jwvfu1g9cxk.fsf-monnier+bug#30190@gnu.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1806211157230.9917@calancha-pc.dy.bbexcite.jp> (Tino Calancha's message of "Thu, 21 Jun 2018 12:07:55 +0900 (JST)")

> I have the bias/personal-preference to avoid load new things when
> I make a change.  Let's call it: 'disturb the least' with my patches.

I'd prefer to re-use comint code rather than copy it.  Copying might be
tolerable for term-watch-for-password-prompt (it could conceivably
require adjustments for the context of term-mode), but it's out of the
question for term-password-prompt-regexp.

> My patch just tried to mimic what is done in `comint.el' and reproduce
> it in `term.el'.  My hope was that the patch would be accepted frictionless:
> if it's already done in `comint.el', why not doing the same in `term.el'?

I'm not a great fan of the hooks in comint (tho I must say I haven't
come up with anything really better either).

And to the extent that you can set *-password-prompt-regexp
buffer-locally in order to prevent *-watch-for-password-prompt from
getting in the way, I don't see much benefit of going through a hook.
[ The hook might be beneficial in itself, with a nil default value, but
  that's a different discussion.  ]


        Stefan





  reply	other threads:[~2018-06-21 19:17 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-21 12:16 bug#30190: 27.0.50; term run in line mode shows user passwords Tino Calancha
2018-01-21 14:01 ` Noam Postavsky
2018-01-21 21:08   ` Tino Calancha
2018-02-03 16:15   ` Tino Calancha
2018-02-03 16:44     ` Noam Postavsky
2018-02-04  2:23       ` Tino Calancha
2018-02-04  2:29         ` Noam Postavsky
2018-02-04  3:37           ` Tino Calancha
2018-02-05  1:07         ` Richard Stallman
2018-02-03 17:08     ` Eli Zaretskii
2018-02-04  2:26       ` Tino Calancha
2018-02-04  3:40       ` Tino Calancha
2018-02-04 12:40         ` Noam Postavsky
2018-02-04 12:47           ` Tino Calancha
2018-02-15  0:09         ` Tino Calancha
2018-02-21 10:18           ` Tino Calancha
2018-02-21 17:47             ` Eli Zaretskii
2018-03-10  8:52               ` Tino Calancha
2018-03-10 10:25                 ` Eli Zaretskii
2018-03-10 10:44                   ` Tino Calancha
2018-03-10 12:07                     ` Eli Zaretskii
2018-03-10 13:17                       ` Tino Calancha
2018-03-10 15:50                         ` Eli Zaretskii
2018-03-11 11:02                           ` Tino Calancha
2018-03-11 17:04                             ` Eli Zaretskii
2018-06-20  4:09                 ` Noam Postavsky
2018-06-20 16:27                   ` Eli Zaretskii
2018-06-20 23:28                     ` Noam Postavsky
2018-06-21  1:31                       ` Tino Calancha
2018-06-21  2:44                       ` Eli Zaretskii
2018-06-21  3:07                         ` Tino Calancha
2018-06-21 19:17                           ` Stefan Monnier [this message]
2018-06-22  3:34                             ` Tino Calancha
2018-06-22 12:44                               ` Stefan Monnier
2018-07-18 11:56                                 ` Noam Postavsky
2018-07-18 12:32                                   ` Tino Calancha
2018-07-18 14:24                                   ` Stefan Monnier
2018-07-18 14:56                                     ` Tino Calancha
2018-07-18 15:54                                       ` Stefan Monnier
2018-07-18 23:28                                         ` Tino Calancha
2018-07-19  1:58                                           ` Stefan Monnier
2018-07-19  2:27                                             ` Noam Postavsky
2018-07-19 12:45                                               ` Stefan Monnier
2018-07-20  7:34                                               ` Tino Calancha
2018-07-19  0:02                                     ` Noam Postavsky
2018-07-19  2:00                                       ` Stefan Monnier
2018-07-22 18:33                                         ` Noam Postavsky
2018-07-22 18:44                                           ` Eli Zaretskii
2018-07-23 12:22                                             ` Noam Postavsky
2018-07-23 12:46                                           ` Stefan Monnier
2018-07-23 12:56                                             ` Tino Calancha
2018-07-24  0:28                                               ` Noam Postavsky
2018-07-24  2:35                                                 ` Eli Zaretskii
2018-07-30  1:15                                                   ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='jwvfu1g9cxk.fsf-monnier+bug#30190@gnu.org' \
    --to=monnier@iro.umontreal.ca \
    --cc=30190@debbugs.gnu.org \
    --cc=npostavs@gmail.com \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.