From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master d826037 3/3: Remove the need for temacs.in Date: Sun, 14 Apr 2019 10:55:38 -0400 Message-ID: References: <20190409224339.20116.87667@vcs0.savannah.gnu.org> <20190409224342.0DA1F20E54@vcs0.savannah.gnu.org> <86697de6baf024290a9d0b10743ba2b7.squirrel@dancol.org> <9093e1cb-7cad-14df-9428-6229313e8f51@cs.ucla.edu> <7bd7a4577abcebd089c7aecc253718f2.squirrel@dancol.org> <0c98c320ec76444fb5af1971d8f99360.squirrel@dancol.org> <064a6c19-760d-a2b6-8f9c-8f7972557b65@cs.ucla.edu> <597d5c5a-f8c1-3b69-006d-6e3da4b1124d@cs.ucla.edu> <838swel7lt.fsf@gnu.org> <83ef64k7k6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="180736"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 14 16:55:54 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hFgXx-000krU-LC for ged-emacs-devel@m.gmane.org; Sun, 14 Apr 2019 16:55:53 +0200 Original-Received: from localhost ([127.0.0.1]:36571 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFgXw-0003kZ-Is for ged-emacs-devel@m.gmane.org; Sun, 14 Apr 2019 10:55:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFgXl-0003kB-Hv for emacs-devel@gnu.org; Sun, 14 Apr 2019 10:55:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hFgXk-0007BH-N7 for emacs-devel@gnu.org; Sun, 14 Apr 2019 10:55:41 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:35846) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFgXk-0007Ap-Ga; Sun, 14 Apr 2019 10:55:40 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x3EEtdj3006752; Sun, 14 Apr 2019 10:55:39 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id ED00E6A134; Sun, 14 Apr 2019 10:55:38 -0400 (EDT) In-Reply-To: <83ef64k7k6.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 14 Apr 2019 17:03:37 +0300") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6524=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6524> : inlines <7052> : streams <1818644> : uri <2831963> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235442 Archived-At: >> > Paul, I think this discussion pointed out that there are no advantages >> > to your change, while it does have disadvantages. >> Hmm... it does have the advantage of speeding up compilation by >> eliminating one `ld` call > By how much? I didn't bother to measure it, but I felt like it is a noticeable difference in some of my use cases (because I sometimes noticed that the make was stopped while linking temacs.in, and because it is also often stopped while linking temacs). > is it significant enough to countermand the disadvantages? It all depends on your beliefs, not on technical issues, I think. The fingerprint is not guaranteed foolproof when computed from the *.o files and is not guaranteed foolproof when made from the temacs.in file either. Also the fingerprint is actually technically only needed to catch misuses (when the user mistakenly uses a snapshot together with the wrong emacs executable). So it's a question of "how much work are we willing to do in order to try and catch misuses". Personally I appreciated the speed up, and found it to be worthwhile compared to the slightly higher risk of not noticing a misuse. But I'll let others choose which color we should choose for this bikeshed. Stefan