From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#35770: [PATCH] Broken duplicate case elimination in switch byte-compilation Date: Fri, 17 May 2019 08:16:30 -0400 Message-ID: References: <91DFE4D0-BDB6-4365-BA51-A2A3F209177C@acm.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="183029"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35770@debbugs.gnu.org, vibhavp@gmail.com To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 17 14:17:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hRbnV-000lRt-Fe for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 May 2019 14:17:13 +0200 Original-Received: from localhost ([127.0.0.1]:47834 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRbnU-00058d-1b for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 May 2019 08:17:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRbnL-00057C-Hx for bug-gnu-emacs@gnu.org; Fri, 17 May 2019 08:17:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRbnK-0002uH-OR for bug-gnu-emacs@gnu.org; Fri, 17 May 2019 08:17:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44138) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hRbnK-0002u0-La for bug-gnu-emacs@gnu.org; Fri, 17 May 2019 08:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hRbnK-0000S4-Fl for bug-gnu-emacs@gnu.org; Fri, 17 May 2019 08:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 May 2019 12:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35770 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org, vibhavp@gmail.com Original-Received: via spool by submit@debbugs.gnu.org id=B.15580954111716 (code B ref -1); Fri, 17 May 2019 12:17:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 17 May 2019 12:16:51 +0000 Original-Received: from localhost ([127.0.0.1]:57682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hRbn9-0000Rc-BF for submit@debbugs.gnu.org; Fri, 17 May 2019 08:16:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hRbn7-0000RP-8w for submit@debbugs.gnu.org; Fri, 17 May 2019 08:16:49 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:44932) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hRbn1-0002a0-At for submit@debbugs.gnu.org; Fri, 17 May 2019 08:16:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45248) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRbn0-00056H-A3 for bug-gnu-emacs@gnu.org; Fri, 17 May 2019 08:16:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRbmy-0002XR-Et for bug-gnu-emacs@gnu.org; Fri, 17 May 2019 08:16:42 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20329) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hRbmw-0002VV-KE for bug-gnu-emacs@gnu.org; Fri, 17 May 2019 08:16:40 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9AE7F4425BE; Fri, 17 May 2019 08:16:37 -0400 (EDT) Original-Received: from mail02.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 72D7B4425B9; Fri, 17 May 2019 08:16:32 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1558095392; bh=LOswXChqXE59WZxt2R5rHAy2Sn7p6fVxQXvsqHsCeqw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=RRgDalvuGauzqe5G4/h49MMPLxJjlq26OnlIydgbe47kL1H8yoZbUil0WbP3oadM1 YT49WKMorrccDr44O91+jx62/cx65p3/XGwlHCV5gChZYu0n/sK9LMkIFTlaFa7qdw kdwN/VzmcfdbKVxz5Y4Af+xNeOnq3ZzaGg9CGFaZqKrJTUdfqa6ZZNO1qaFzcuudFo QMVRrv3RwF0hwpErRN9s6uMn2qM7vCIvITQu08S1Ey2+WgukJ3iLDbpI7/gNP2k+Zo KxWwrtpIGFH8CrBPckxXOJWo79jZAf5jA0OXYEJudWEfKeaumB4Ske6sXCQOjsUVMy M+OXjcwt48/9Q== Original-Received: from pastel (184-175-13-248.dsl.teksavvy.com [184.175.13.248]) by mail02.iro.umontreal.ca (Postfix) with ESMTPSA id 3EED912023B; Fri, 17 May 2019 08:16:32 -0400 (EDT) In-Reply-To: <91DFE4D0-BDB6-4365-BA51-A2A3F209177C@acm.org> ("Mattias \=\?windows-1252\?Q\?Engdeg\=E5rd\=22's\?\= message of "Fri, 17 May 2019 11:33:41 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159443 Archived-At: > * lisp/emacs-lisp/bytecomp.el (byte-compile-cond-vars): Return obj2 eval'ed. > (byte-compile-cond-jump-table-info): > Discard redundant condition. Use `obj2' as evaluated. > Discard duplicated cases instead of failing the table generation. The patch looks fine, but could you add corresponding regression tests? Stefan