From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 35770@debbugs.gnu.org, vibhavp@gmail.com
Subject: bug#35770: [PATCH] Broken duplicate case elimination in switch byte-compilation
Date: Fri, 17 May 2019 08:16:30 -0400 [thread overview]
Message-ID: <jwvftpd46qr.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <91DFE4D0-BDB6-4365-BA51-A2A3F209177C@acm.org> ("Mattias \=\?windows-1252\?Q\?Engdeg\=E5rd\=22's\?\= message of "Fri, 17 May 2019 11:33:41 +0200")
> * lisp/emacs-lisp/bytecomp.el (byte-compile-cond-vars): Return obj2 eval'ed.
> (byte-compile-cond-jump-table-info):
> Discard redundant condition. Use `obj2' as evaluated.
> Discard duplicated cases instead of failing the table generation.
The patch looks fine, but could you add corresponding regression tests?
Stefan
next prev parent reply other threads:[~2019-05-17 12:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 9:33 bug#35770: [PATCH] Broken duplicate case elimination in switch byte-compilation Mattias Engdegård
2019-05-17 12:16 ` Stefan Monnier [this message]
2019-05-17 14:48 ` Mattias Engdegård
2019-05-22 10:52 ` Mattias Engdegård
2019-05-22 10:58 ` Eli Zaretskii
2019-05-22 11:11 ` Mattias Engdegård
2019-05-22 11:21 ` Noam Postavsky
2019-05-22 11:23 ` Eli Zaretskii
2019-05-22 14:19 ` Stefan Monnier
2019-05-26 17:05 ` Mattias Engdegård
2019-05-26 18:43 ` Eli Zaretskii
2019-05-26 22:06 ` Stefan Monnier
2019-05-27 11:27 ` Mattias Engdegård
2019-06-01 13:58 ` Noam Postavsky
2019-06-01 15:47 ` Eli Zaretskii
2019-06-01 21:53 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvftpd46qr.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=35770@debbugs.gnu.org \
--cc=mattiase@acm.org \
--cc=vibhavp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.