From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#39190: 28.0.50; two buffers with same buffer-file-name (diff-syntax-fontify-props) Date: Sun, 02 Feb 2020 08:50:07 -0500 Message-ID: References: <875zh73dg8.fsf@betli.tmit.bme.hu> <8736c921s6.fsf@mail.linkov.net> <875zh13e5d.fsf@mail.linkov.net> <87h80iqafm.fsf@betli.tmit.bme.hu> <87ftg0fnyb.fsf@mail.linkov.net> <87d0b3qz3m.fsf@betli.tmit.bme.hu> <871rrhkgkm.fsf@mail.linkov.net> <87v9os914e.fsf@betli.tmit.bme.hu> <87a764y35u.fsf@mail.linkov.net> <87r1zd8gvx.fsf@betli.tmit.bme.hu> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="83691"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 39190@debbugs.gnu.org, Juri Linkov To: Felician Nemeth Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 02 14:51:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iyFee-000Lcz-3Z for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Feb 2020 14:51:16 +0100 Original-Received: from localhost ([::1]:56368 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iyFed-0006iK-2M for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Feb 2020 08:51:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55010) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iyFeV-0006i2-Tw for bug-gnu-emacs@gnu.org; Sun, 02 Feb 2020 08:51:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iyFeT-0001IW-Fk for bug-gnu-emacs@gnu.org; Sun, 02 Feb 2020 08:51:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33649) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iyFeS-0001Hw-Bu for bug-gnu-emacs@gnu.org; Sun, 02 Feb 2020 08:51:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iyFeQ-0001oO-Av for bug-gnu-emacs@gnu.org; Sun, 02 Feb 2020 08:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Feb 2020 13:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39190 X-GNU-PR-Package: emacs Original-Received: via spool by 39190-submit@debbugs.gnu.org id=B39190.15806514196903 (code B ref 39190); Sun, 02 Feb 2020 13:51:02 +0000 Original-Received: (at 39190) by debbugs.gnu.org; 2 Feb 2020 13:50:19 +0000 Original-Received: from localhost ([127.0.0.1]:39622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iyFdj-0001nE-E4 for submit@debbugs.gnu.org; Sun, 02 Feb 2020 08:50:19 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:51871) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iyFdh-0001n1-DE for 39190@debbugs.gnu.org; Sun, 02 Feb 2020 08:50:17 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 016EB8136F; Sun, 2 Feb 2020 08:50:12 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 3AD4980D5A; Sun, 2 Feb 2020 08:50:09 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1580651409; bh=MRMLtmfKiZmhH39qPrsOaRro59dmQ1FfL6/UYUv2U6U=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=N94fsQO4DHspwlkpksdL+uV62K7XF9i0gDigVpY7Qv0osOW87QZdLWzYJxUANFCh2 MynWtBCyXnWFDbVTuROSxJIcA7xmgdFgzq1dkoEqMT8gbFFQR9hNmkTge0xFoc6IbW t+jrekERTjoQi7GwS0Ez9x1raakQNAtFC5JpcNla3hHXsiz8FwOUFnf09vdicvu2eh g1YmsKRKxnzrojtd/r1m95cfsSqb0n107d2AoU2pIJs4lgzRdF9aG3rNVxfbllt9g0 aRgY20NYMtDRyDOsKCSleykLR9s72czSXwgu8VybQ3MnaXZ+NrV257HOMnVBbnlpA1 55T2+x+yxNGkw== Original-Received: from pastel (unknown [216.154.34.88]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C73EF120FEA; Sun, 2 Feb 2020 08:50:08 -0500 (EST) In-Reply-To: <87r1zd8gvx.fsf@betli.tmit.bme.hu> (Felician Nemeth's message of "Sun, 02 Feb 2020 10:42:26 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175584 Archived-At: > vc-find-revision-no-save also calls set-auto-mode. So, I don't know if > the following patch is correct, but together with your patch it does > solve the original issue. > > diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el > index f64b6c0631..c50ba132e7 100644 > --- a/lisp/vc/vc.el > +++ b/lisp/vc/vc.el > @@ -2098,7 +2098,7 @@ vc-find-revision-no-save > ;; For non-interactive, skip any questions > (let ((enable-local-variables :safe) ;; to find `mode:' > (buffer-file-name file)) > - (ignore-errors (set-auto-mode))) > + (ignore-errors (delay-mode-hooks (set-auto-mode)))) > (normal-mode)) > (set-buffer-modified-p nil) > (setq buffer-read-only t)) How 'bout we first consolidate the two cases into one by introducing a new function `set-auto-mode-for-filename` that both vc-find-revision-no-save and diff-mode can use? Stefan