From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#39808: 28.0.50; toolbar broken Date: Thu, 27 Feb 2020 12:33:50 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="12654"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Markus FFM , 39808@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 27 18:34:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j7N38-0003Cg-N2 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Feb 2020 18:34:14 +0100 Original-Received: from localhost ([::1]:35506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7N37-0003y0-Pn for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Feb 2020 12:34:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52068) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7N2x-0003xe-OI for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 12:34:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7N2w-0005Ry-PH for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 12:34:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54262) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j7N2w-0005RT-8R for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 12:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j7N2w-0002gH-2O for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 12:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Feb 2020 17:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39808 X-GNU-PR-Package: emacs Original-Received: via spool by 39808-submit@debbugs.gnu.org id=B39808.158282484110299 (code B ref 39808); Thu, 27 Feb 2020 17:34:01 +0000 Original-Received: (at 39808) by debbugs.gnu.org; 27 Feb 2020 17:34:01 +0000 Original-Received: from localhost ([127.0.0.1]:60235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7N2v-0002g3-75 for submit@debbugs.gnu.org; Thu, 27 Feb 2020 12:34:01 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:40635) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7N2s-0002fn-Rn for 39808@debbugs.gnu.org; Thu, 27 Feb 2020 12:33:59 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 506A1100ECB; Thu, 27 Feb 2020 12:33:53 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 672F0100E87; Thu, 27 Feb 2020 12:33:51 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1582824831; bh=Bp6viMeJx5FHyUJgrEagsCEnTWrJjoKLkCGi1+Mqo0E=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Z3uJKeHKdfIcxNvI7YVg0kPvUnHW2eVYWbks0XGbtjKRuYRyudu5d+kqYA1g5muvr D8QKJFRV4U7+Yw1snYHd4MbLQ1NEJ0Q6z6SwGp8dePTtlhSKgci0xt+ROaQUxnUDsH EVZyzAXv81kf70qdqDRfEY60qS5yRWWE+IlX8bJv2tSTScWfqmVEIBImiwhppDKEGk KxG3PMO7fbya3PIiIcNd7NgQHhGnl6dGCfRv7FGnJ/loIhD0az9Xjlj99lL24Vaklb +g0xsqtGlMx0RIyzVNLM27Mb8M75qLrtB92A2sqjT7Y14P5k4fhl51ybM7uiLPwU3M JYStQ8s5naqDw== Original-Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 420CC120230; Thu, 27 Feb 2020 12:33:51 -0500 (EST) In-Reply-To: (Robert Pluim's message of "Thu, 27 Feb 2020 17:43:46 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176538 Archived-At: > Stefan> Looks like my grep-fu was very weak, indeed. > The '.m' used by the NS files always trips me up. Yes, that's the regular weakness. But in the present case I also missed the occurrence in the gtkutil.c file. I have no idea how that happened. > Stefan> I installed the patch below, which should hopefully fix > Stefan> the problem for Gtk and NS builds, > > That fixes it for GTK. For NS, the buffer does not get killed, and I > get the following in the terminal: [...] > I think you were over-enthusiastic with your pruning, I put back the > initialisation of theEvent, that fixes this (I=CA=BCm a bit pressed for > time tonight, so can=CA=BCt commit it right now). Thanks, I pushed it for you, Stefan