From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: scratch/eldoc-xref-project-gnu-elpa-core-packages b1631cd: Turn Eldoc, Xref and Project into GNU ELPA :core packages Date: Mon, 11 May 2020 19:17:39 -0400 Message-ID: References: <20200511214134.32634.30981@vcs0.savannah.gnu.org> <20200511214135.F14AF20A23@vcs0.savannah.gnu.org> <54168518-e95e-4eaa-0227-b51466d86cb2@yandex.ru> <87ftc6f7ex.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="30432"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Dmitry Gutov To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 12 01:18:20 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jYHgh-0007mS-Am for ged-emacs-devel@m.gmane-mx.org; Tue, 12 May 2020 01:18:19 +0200 Original-Received: from localhost ([::1]:43436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYHgg-0005t6-Bv for ged-emacs-devel@m.gmane-mx.org; Mon, 11 May 2020 19:18:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56456) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYHgC-000510-13 for emacs-devel@gnu.org; Mon, 11 May 2020 19:17:48 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:38215) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYHg7-0006Cr-RB for emacs-devel@gnu.org; Mon, 11 May 2020 19:17:47 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4C09F1009B2; Mon, 11 May 2020 19:17:42 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 6A55610099B; Mon, 11 May 2020 19:17:40 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1589239060; bh=8BTxoEDEAlhN6/AW+uuMNeVm3nvZgI4wHJCWuG4mGco=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Dme8wD/gKJHFxJziTd9K335ztZZIMrjxAwzC5FDnL5K0ffWG4XxCUQUMokcErOhFx B64hJ8/3Bxzl1lvS1sEXvreXFxIuiinSfJB7eaM0enf5VMFEIC8IL6ioGPSbRRHwhM wCCO8Ma3rJofVDHcrlh74ApVQzi0XUSdsidRch6xyL8t69VzV8enGt1vo5M/befz0c q94oPV83AxSCTcSO6KwAgYDIRn0pMoi5P8EV+R5L74ZowYMN8p48lldDRa4tCxXAbV 6zVlsFO7x2V6fu/5f3ChuQ6RNq9LBeVU7NIjFo8O/SBvD0vSkN9AFtsr5bH7WG4UFC moE3fGIhm9prw== Original-Received: from alfajor (unknown [216.154.3.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 18456120554; Mon, 11 May 2020 19:17:40 -0400 (EDT) In-Reply-To: <87ftc6f7ex.fsf@gmail.com> (=?windows-1252?Q?=22Jo=E3o_T=E1vo?= =?windows-1252?Q?ra=22's?= message of "Mon, 11 May 2020 23:12:06 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/11 10:58:52 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:249906 Archived-At: > 1. xref and project.el have a cyclic dependency. xref.el depends > (properly) on project.el but it seems project.el also depends on > xref.el. > > (defun project--files-in-directory (dir ignores &optional files) > (require 'find-dired) > (require 'xref) > (defvar find-name-arg) > > How should I fix this? Any ideas? Or should I be creative? IIUC a significant part of project's functionality works fine without xref, so you could consider that project does not Package-Require `xref`. Also it's worth checking if it depend on a *recent* version of xref, or if it also work with the xref that comes with Emacs-26 or even Emacs-25. Another option is to bundle them into a single package (`:core` packages can be composed of several files, see `soap-client` for an example). > 2. It'd be nice if both xref.el and project.el were available for Emacs > 26.3. But project.el in Emacs master depends on fileloop.el, This dependency is of no real importance: it's only used to provide the two commands `project-search` and `project-query-replace-regexp` for which there are many alternatives anyway. So I wouldn't worry about it. We could simply change the code to test (fboundp 'fileloop-initialize-replace) and signal a cleaner error (mentioning that these commands only work in Emacs=E2=89=A527) than "void-function". Stefan