From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v2 01/16] Add a test for let-binding unwinding Date: Wed, 25 Nov 2020 15:53:20 -0500 Message-ID: References: <20201119153814.17541-1-sbaugh@catern.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32994"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Arnold Noronha , Dmitry Gutov , emacs-devel@gnu.org To: Spencer Baugh Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 25 21:54:03 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ki1nd-0008SV-Me for ged-emacs-devel@m.gmane-mx.org; Wed, 25 Nov 2020 21:54:01 +0100 Original-Received: from localhost ([::1]:49116 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ki1nc-0005vy-Ot for ged-emacs-devel@m.gmane-mx.org; Wed, 25 Nov 2020 15:54:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ki1n5-0005OC-29 for emacs-devel@gnu.org; Wed, 25 Nov 2020 15:53:28 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:9727) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ki1n2-00025m-Bk for emacs-devel@gnu.org; Wed, 25 Nov 2020 15:53:26 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B56A38009B; Wed, 25 Nov 2020 15:53:22 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E067280853; Wed, 25 Nov 2020 15:53:20 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1606337600; bh=5e6onYU2I47hmE7cDrjhUfjqAlJHLKy0t+evxx8Ymrw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZNXSRTA9JcbKelAFs4Md6kjV7CVFzN+IrOFh2LE6LW0he3IrE/EpNEgCXopLyAyu1 ZVpE6JQUsNAGC+X6H9LHZAyP5XsUt/S2pYi+WSh6vhlZsZdIo4aDm7SYg9G/apSyF/ F0XD0ZzVq6M+dsbT3pTgJI70g/C/KS77867mdRTGYzOcyXetSIQoJDzCevw4Xf/Of4 vh3ukOeKoKA7FkiXqPGdlECXy3OxGgVfE1olQ34DStw5Qnj2VdP1UC3ieopBwSkGP2 LZ/j0hibgthkVOvumV3TIcEvS+dUy5Y4qq1niU+AhzorSrEM7hKpDVNjzQKLW0BICP JexPlkDT+IoxQ== Original-Received: from alfajor (69-165-136-52.dsl.teksavvy.com [69.165.136.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A2DA6120325; Wed, 25 Nov 2020 15:53:20 -0500 (EST) In-Reply-To: (Spencer Baugh's message of "Sat, 21 Nov 2020 21:34:30 -0500") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259809 Archived-At: > diff --git a/test/src/data-tests.el b/test/src/data-tests.el > index 1312683c84..7e69b9c331 100644 > --- a/test/src/data-tests.el > +++ b/test/src/data-tests.el > @@ -364,6 +364,28 @@ comparing the subr with a much slower lisp implementation." > (should (equal (default-value var) (symbol-value var)))) > (should (equal (default-value var) def)))))) > > +(ert-deftest data-tests--let-buffer-local-no-unwind-other-buffers () > + "Test that a let-binding for a buffer-local unwinds only current-buffer" Missing "." at the end. > + (let ((blvar (make-symbol "blvar"))) > + (set-default blvar 0) > + (make-variable-buffer-local blvar) > + (dolist (var (list blvar 'left-margin)) > + (let* ((def (default-value var)) > + (newdef (+ def 1)) > + (otherbuf (generate-new-buffer "otherbuf"))) > + (with-temp-buffer > + (cl-progv (list var) (list newdef) > + (with-current-buffer otherbuf > + (set var 123) > + (should (local-variable-p var)) > + (should (equal (symbol-value var) 123)) > + (should (equal (default-value var) newdef)))) > + (with-current-buffer otherbuf > + (should (local-variable-p var)) > + (should (equal (symbol-value var) 123)) > + (should (equal (default-value var) def))) > + ))))) LGTM Stefan