all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Philipp Stephani <p.stephani2@gmail.com>, emacs-devel@gnu.org
Subject: Re: What's the line length limit in the Emacs codebase?
Date: Wed, 23 Dec 2020 11:55:23 -0500	[thread overview]
Message-ID: <jwvft3wv5b0.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83wnx8pm0e.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 23 Dec 2020 17:42:09 +0200")

>> There seem to be conflicting settings for the line length limit in the
>> Emacs codebase: .dir-locals.el sets fill-column to 70, but large areas
>> of the source code (including comments) seem to use 80. Can we pick
>> one value and use it consistently (for new/changed code)?
>
> 70 is it, we just don't necessarily enforce it religously.
>
> Where did you see significant deviations from that standard?

Indeed.  I'd say that we it's a kind of progressive limit:
- it's OK to have all lines ≤ 70-columns wide
- it's not OK to have most lines >70-columns
- we tolerate reaching the area between 70 and 80 columns every once in
  a while, tho.
- ≥80 columns OTOH should really be rare, limited to the exceptional
  cases where the alternative is really worse.


        Stefan




  reply	other threads:[~2020-12-23 16:55 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-23  9:58 What's the line length limit in the Emacs codebase? Philipp Stephani
2020-12-23 15:42 ` Eli Zaretskii
2020-12-23 16:55   ` Stefan Monnier [this message]
2020-12-23 21:21     ` Karl Fogel
2020-12-24  3:37       ` Eli Zaretskii
2020-12-25 17:11     ` Philipp Stephani
2020-12-25 17:43       ` Stefan Monnier
2020-12-26 11:02         ` Philipp Stephani
2020-12-26 16:30           ` Stefan Monnier
2020-12-27  5:38           ` Richard Stallman
2020-12-25 20:32       ` tomas
2020-12-26 10:38         ` Michael Albinus
2020-12-26 11:17           ` Yuri Khan
2020-12-26 11:22             ` Michael Albinus
2020-12-26 11:36               ` Yuri Khan
2020-12-26 12:21                 ` tomas
2020-12-26 18:31           ` Drew Adams
2020-12-26 11:12         ` Philipp Stephani
2020-12-25 17:10   ` Philipp Stephani
2020-12-25 19:04     ` Eli Zaretskii
2020-12-26 11:09       ` Philipp Stephani
2020-12-26 11:14         ` Eli Zaretskii
2020-12-26 10:24     ` Richard Stallman
2020-12-26 11:04       ` Philipp Stephani
2020-12-26 18:43         ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvft3wv5b0.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.