From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] When deleting in bookmark menu, prompt for confirmation. Date: Mon, 03 May 2021 09:02:08 -0400 Message-ID: References: <87a6pcqy7s.fsf@red-bean.com> <87mttcch39.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24608"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Karl Fogel , Lars Ingebrigtsen , Emacs Development To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 03 15:09:01 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldYJp-0006FF-9K for ged-emacs-devel@m.gmane-mx.org; Mon, 03 May 2021 15:09:01 +0200 Original-Received: from localhost ([::1]:60424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldYJo-0005Qy-AW for ged-emacs-devel@m.gmane-mx.org; Mon, 03 May 2021 09:09:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldYDH-0007wN-Ob for emacs-devel@gnu.org; Mon, 03 May 2021 09:02:15 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:50229) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldYDD-0001dA-PO for emacs-devel@gnu.org; Mon, 03 May 2021 09:02:15 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DF4664407B3; Mon, 3 May 2021 09:02:10 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id ADF314407AB; Mon, 3 May 2021 09:02:09 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1620046929; bh=nqzwYBS6yc5WdVmWMR+29nSxdpUKgzLTHD1ahZiIs1Y=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=j//FUo9xx26PSGvHFlBNeDX3nbJuX4arludDJqTkosQEA7TnqnfO1jd1KRcVLvo8s 8T0yKA+MxAl/trvW3Tkyt1srHiU8KSCONJi7QUsHxMwlQWG2O88TGn1esOo9YD+bIQ fCLHZd+2ocrEFLeqagr/b4vr+I8sT4LSEE+oDE+sX5DUVN5IuArWQdd30981Kfl+LF DWDWOzbX6i7PmNnV4OwUtV+GfeRYd8m7Ouu8Sla06LQRtFZeNQp0anHJsBcEX1KLQ3 0Iqsdbk5p17t49g3ma2jszs/y10j88PmGoll/2XoXAB+sQwWYdj4qbFBr5P2j19UMt usk017cuGtU0w== Original-Received: from alfajor (unknown [108.161.125.61]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6690F1203C4; Mon, 3 May 2021 09:02:09 -0400 (EDT) In-Reply-To: (Stefan Kangas's message of "Mon, 3 May 2021 07:48:00 -0500") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268811 Archived-At: >> In general, I think it's better to offer undo instead of prompting. >> That's not always possible, but I think in the bookmark case, that >> shouldn't be too difficult -- just register an undo action that inserts >> the items that were removed, I think? Sounds like a good idea, yes. > I think a confirmation here is in order, as this is a dangerous > operation. For the same reason, we should ask the user to disable the > prompt rather than the other way around, i.e. the default should be t. I don't have an opinion, but having undo would be beneficial in any case (i.e. regardless of the confirmation). Stefan