From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Stefan Kangas <stefan@marxist.se>
Cc: Karl Fogel <kfogel@red-bean.com>,
Lars Ingebrigtsen <larsi@gnus.org>,
Emacs Development <emacs-devel@gnu.org>
Subject: Re: [PATCH] When deleting in bookmark menu, prompt for confirmation.
Date: Mon, 03 May 2021 09:02:08 -0400 [thread overview]
Message-ID: <jwvfsz4ug3l.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CADwFkmnSJA11MiPtNte8zubVX6u7RBb-B_sLuoqXhvk_6TxXog@mail.gmail.com> (Stefan Kangas's message of "Mon, 3 May 2021 07:48:00 -0500")
>> In general, I think it's better to offer undo instead of prompting.
>> That's not always possible, but I think in the bookmark case, that
>> shouldn't be too difficult -- just register an undo action that inserts
>> the items that were removed, I think?
Sounds like a good idea, yes.
> I think a confirmation here is in order, as this is a dangerous
> operation. For the same reason, we should ask the user to disable the
> prompt rather than the other way around, i.e. the default should be t.
I don't have an opinion, but having undo would be beneficial in any case
(i.e. regardless of the confirmation).
Stefan
next prev parent reply other threads:[~2021-05-03 13:02 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 3:43 [PATCH] When deleting in bookmark menu, prompt for confirmation Karl Fogel
2021-05-03 9:16 ` Lars Ingebrigtsen
2021-05-03 12:48 ` Stefan Kangas
2021-05-03 13:02 ` Stefan Monnier [this message]
2021-05-04 7:53 ` Lars Ingebrigtsen
2021-05-04 16:29 ` [External] : " Drew Adams
2021-05-03 11:41 ` Eli Zaretskii
2021-05-03 12:47 ` Stefan Kangas
2021-05-03 13:16 ` Eli Zaretskii
2021-05-03 15:43 ` Stefan Kangas
2021-05-03 16:25 ` Eli Zaretskii
2021-05-03 17:21 ` Karl Fogel
2021-05-03 17:41 ` Eli Zaretskii
2021-05-03 18:28 ` Jim Porter
2021-05-03 18:44 ` Eli Zaretskii
2021-05-03 19:01 ` Jim Porter
2021-05-03 20:52 ` Karl Fogel
2021-05-05 5:24 ` Karl Fogel
2021-05-05 8:11 ` Lars Ingebrigtsen
2021-05-05 19:37 ` Karl Fogel
2021-05-05 20:06 ` Stefan Monnier
2021-05-05 21:38 ` Karl Fogel
2021-05-05 23:17 ` [External] : " Drew Adams
2021-05-05 23:25 ` Karl Fogel
2021-05-06 6:52 ` Matthias Meulien
2021-05-06 15:29 ` Drew Adams
2021-05-08 20:46 ` Matthias Meulien
2021-05-09 8:54 ` Eli Zaretskii
2021-05-09 18:37 ` Karl Fogel
2021-05-09 18:39 ` Eli Zaretskii
2021-05-25 5:38 ` Karl Fogel
2021-05-25 12:09 ` Eli Zaretskii
2021-05-25 20:24 ` Karl Fogel
2021-05-26 11:59 ` Eli Zaretskii
2021-05-26 19:33 ` Karl Fogel
2021-05-07 17:42 ` Karl Fogel
2021-05-07 22:24 ` Drew Adams
2021-05-08 6:13 ` Karl Fogel
2021-05-06 8:49 ` Lars Ingebrigtsen
2021-05-06 13:30 ` Stefan Monnier
2021-05-07 8:40 ` Lars Ingebrigtsen
2021-05-07 12:55 ` Stefan Monnier
2021-05-09 9:55 ` Lars Ingebrigtsen
2021-05-09 15:04 ` Stefan Kangas
2021-05-09 18:01 ` Stefan Monnier
2021-05-10 8:30 ` Lars Ingebrigtsen
2021-05-07 17:40 ` Karl Fogel
2021-05-05 11:56 ` Eli Zaretskii
2021-05-05 21:43 ` Karl Fogel
2021-05-03 17:43 ` [External] : " Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvfsz4ug3l.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=kfogel@red-bean.com \
--cc=larsi@gnus.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.