From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#55938: [PATCH] bindat (strz): Error on null byte if packing variable-length string Date: Mon, 13 Jun 2022 09:12:20 -0400 Message-ID: References: Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39609"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 55938@debbugs.gnu.org To: Richard Hansen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 13 15:13:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o0jsh-000A6k-1e for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Jun 2022 15:13:23 +0200 Original-Received: from localhost ([::1]:52052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o0jsf-0000Ia-Lz for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Jun 2022 09:13:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0jsM-0000II-RF for bug-gnu-emacs@gnu.org; Mon, 13 Jun 2022 09:13:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35470) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o0jsM-0002DZ-JI for bug-gnu-emacs@gnu.org; Mon, 13 Jun 2022 09:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o0jsM-0003vN-E2 for bug-gnu-emacs@gnu.org; Mon, 13 Jun 2022 09:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Jun 2022 13:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55938 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55938-submit@debbugs.gnu.org id=B55938.165512595415040 (code B ref 55938); Mon, 13 Jun 2022 13:13:02 +0000 Original-Received: (at 55938) by debbugs.gnu.org; 13 Jun 2022 13:12:34 +0000 Original-Received: from localhost ([127.0.0.1]:57600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0jrt-0003uW-Ul for submit@debbugs.gnu.org; Mon, 13 Jun 2022 09:12:34 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:46519) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0jrt-0003uJ-1o for 55938@debbugs.gnu.org; Mon, 13 Jun 2022 09:12:33 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4BA4B8079A; Mon, 13 Jun 2022 09:12:27 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4FC028035A; Mon, 13 Jun 2022 09:12:25 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1655125945; bh=sHhPU3IjmtMl56BHbpfe9i+Ub/mp/GIx+wjw6ueceps=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=W+fNdJHRf0L5H69stBLyBG+VcbNpa49tOWDM3uEcLYTz6b6raKC2h6oIp33/FKrTB n2k7HE3qAzTn29CUYB0BCxl6WBTtjmySohO3n37nCRvvZzxGRf1kWfOlN1m2mo6My6 xtFtuRvsJJGn6NU2YwWZA1uG0h88N4zTRdlcudf3LI+5TsevCWLpg6LtkDz7LSpedJ zvaO6rnN6CrNDzo+CLmBcsAVFuu4PbDtb4Vo29l65MpoERRchbSJvcqVnEkcY5t7py 2MkYY8GVwSOyzuNOsD62x4PMl95Dwi12C8m+BlJGB9TlCHVchY71Sdy2qocCPRDCta s475E+9Ll20kQ== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C50171204D7; Mon, 13 Jun 2022 09:12:24 -0400 (EDT) In-Reply-To: (Richard Hansen's message of "Mon, 13 Jun 2022 01:48:11 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234399 Archived-At: > (let* ((v (string-to-unibyte v)) > (len (length v))) > (dotimes (i len) > + (if (= (aref v i) 0) > + ;; Alternatively we could pretend that this was the end of > + ;; the string and stop packing, but then bindat-length would > + ;; need to scan the input string looking for a null byte. > + (error "Null byte encountered in input strz string")) I suspect a `string-match` looking for NUL would be faster. Stefan