From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#58158: 29.0.50; [overlay] Interval tree iteration considered harmful Date: Thu, 29 Sep 2022 18:09:01 -0400 Message-ID: References: <83h70qhez0.fsf@gnu.org> <83edvuhaby.fsf@gnu.org> <831qruh67o.fsf@gnu.org> <83y1u2foli.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14566"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , 58158@debbugs.gnu.org To: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 30 00:10:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oe1ja-0003aR-39 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Sep 2022 00:10:22 +0200 Original-Received: from localhost ([::1]:53582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oe1jY-0001N6-IO for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Sep 2022 18:10:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46210) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oe1jG-0001My-Vg for bug-gnu-emacs@gnu.org; Thu, 29 Sep 2022 18:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40783) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oe1jG-0006uO-GP for bug-gnu-emacs@gnu.org; Thu, 29 Sep 2022 18:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oe1jG-00029I-BU for bug-gnu-emacs@gnu.org; Thu, 29 Sep 2022 18:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Sep 2022 22:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58158 X-GNU-PR-Package: emacs Original-Received: via spool by 58158-submit@debbugs.gnu.org id=B58158.16644893538197 (code B ref 58158); Thu, 29 Sep 2022 22:10:02 +0000 Original-Received: (at 58158) by debbugs.gnu.org; 29 Sep 2022 22:09:13 +0000 Original-Received: from localhost ([127.0.0.1]:39860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oe1iT-000288-Ej for submit@debbugs.gnu.org; Thu, 29 Sep 2022 18:09:13 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:4085) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oe1iQ-00027u-N6 for 58158@debbugs.gnu.org; Thu, 29 Sep 2022 18:09:11 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4A4B180740; Thu, 29 Sep 2022 18:09:05 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id ACC3A802A7; Thu, 29 Sep 2022 18:09:03 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1664489343; bh=aAWjzvAwYgtD09bYnVK4/L2jLPJB9KvaFH21lBFahcw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=NSBvLEPNw30njsvZBXXzZ4UplSRrQMaV6Hxl84KzJGac4wDGfVps2zNpsIZMr32b1 LMLhEMJupVvLl6voQa0DZ5CMCGyicPaddPtwxexIOjWWXxzbJ0Q2Pf2ROtHMof4Lmt iW9z1yF/UBtS7Uryp9/yoyqSQscVH+ZTAcHLN6YwA8PGLosQSOFSwI+ZwW5XRYdc2g EQ2iKHqFUGn2SSYyeL/QIKKr6LtPl3Dhlgcs4xaPApn9sOyfIhR2f9HPLQt/vR5Xnh lPF0Az7PX3mUmhvjTzaVPtYSaOT4lPeeAyTUlgJWSzD0z9fYFXkT2MyuNawIAsc1+E jnUFZkAQ4FrQg== Original-Received: from pastel (65-110-220-202.cpe.pppoe.ca [65.110.220.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6984E1203FE; Thu, 29 Sep 2022 18:09:03 -0400 (EDT) In-Reply-To: ("Gerd =?UTF-8?Q?M=C3=B6llmann?="'s message of "Thu, 29 Sep 2022 16:37:51 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243957 Archived-At: > static _Rb_tree_node_base* > local_Rb_tree_increment(_Rb_tree_node_base* __x) throw () > { > if (__x->_M_right != 0) > { > __x = __x->_M_right; > while (__x->_M_left != 0) > __x = __x->_M_left; > } > else > { > _Rb_tree_node_base* __y = __x->_M_parent; > while (__x == __y->_M_right) > { > __x = __y; > __y = __y->_M_parent; > } > if (__x->_M_right != __y) > __x = __y; > } > return __x; > } > > I hope one can read that. I changed the code to store the `visited` bit in the work stack, but if you could rewrite the `interval_generator_next` along the lines of the code above that would be great. [ An alternative would be to try and get rid of the `parent` field :-) ] Stefan