From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces Date: Sun, 06 Nov 2022 09:05:01 -0500 Message-ID: References: <835yfxbkyy.fsf@gnu.org> <8ZKenedKBW2xqbSe_c0vWmeRbMQYCDlwFNvSMAYx9utQYeOKPHQQ-nKW9Y8nCcKRnFMmsnfonvA_0yixtSArBzVY_PkaNxxGWqhXoHjCZTo=@rjt.dev> <83cza14uuq.fsf@gnu.org> <83cza038yn.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6178"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Randy Taylor , casouri@gmail.com, 58940@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 06 15:06:42 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1orgIM-0001Pc-6f for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Nov 2022 15:06:42 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1orgHy-0000Yg-Sz; Sun, 06 Nov 2022 09:06:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orgHm-0000W7-75 for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2022 09:06:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1orgHi-0005ED-7g for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2022 09:06:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1orgHi-0007Gk-34 for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2022 09:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Nov 2022 14:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58940 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58940-submit@debbugs.gnu.org id=B58940.166774351227832 (code B ref 58940); Sun, 06 Nov 2022 14:06:02 +0000 Original-Received: (at 58940) by debbugs.gnu.org; 6 Nov 2022 14:05:12 +0000 Original-Received: from localhost ([127.0.0.1]:58990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orgGu-0007Eq-DJ for submit@debbugs.gnu.org; Sun, 06 Nov 2022 09:05:12 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:36142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orgGt-0007Eb-9C for 58940@debbugs.gnu.org; Sun, 06 Nov 2022 09:05:11 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 46222100189; Sun, 6 Nov 2022 09:05:05 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3CA2B1000EF; Sun, 6 Nov 2022 09:05:03 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1667743503; bh=kr6Ypi49Pxmx3L1zzYkgc//o2+q//5gB1eWH8fuuhXM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=gDqEqAO6auLBKwV5kynOxrF+CeMU9XGKaau/loSgCKpKfuZARktM99fTvQOpvPC4E tukuYSeg4me3VPMLkfZZ2LVVrgAK4dXFLiFzp+AbfQtmV93i8wqouKBNPSuwaCoWbe 1aSJBezj8f37J1rLewrWzlEdPLhxmfuzn7AbbHdVYx60sq+ZIeftM/H6gR2gkCqXFW aiBkfJF9gCDeB82vsduzURCr2bBQBe9eNoRwsyOa/hJKRuPuAubt8L3lVGO7B9Pn5F IypgFiqgRBKO3nfFblKhuNEBL7bXjxhhS/nvlRSlBGuN1tYsXUy15NubnyUNZpqp5t Uz0id7+Y/O4PA== Original-Received: from pastel (unknown [104.247.241.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 002611208AC; Sun, 6 Nov 2022 09:05:02 -0500 (EST) In-Reply-To: <83cza038yn.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 06 Nov 2022 08:14:56 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247210 Archived-At: >> BTW I see that font-lock-regexp-grouping-{backslash,construct} >> do not have related variables like the rest of the faces. Why is that? > > No idea. I didn't even know we had those faces until I've read your > patch. > > Stefan, any idea why those faces don't have variables? Not really, no. But AFAIK the "variable associated with a face" is an old idiosyncrasy of `font-lock.el` that's never been explained nor justified. It was used at some point for customization purposes (to tweak the face buffer-locally) but we introduced the face-remapping facility as a better replacement for that hack, so faces should not need accompanying vars since Emacs-23. I suspect that's part of the reason. Ideally, we'd phase out those old `font-lock-*-face` variables rather than introduce new ones. I think the only thing they bring nowadays is confusion. Stefan