From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59914: [GNU ELPA] Make use-package and bind-key into :core packages Date: Fri, 09 Dec 2022 09:56:14 -0500 Message-ID: References: Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18931"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: John Wiegley , 59914@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 09 15:57:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p3eoS-0004j9-Ku for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Dec 2022 15:57:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3eoD-0005Jc-Bx; Fri, 09 Dec 2022 09:57:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3eoB-0005J4-8C for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 09:57:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3eoA-0003rI-UL for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 09:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p3eoA-0005TG-QT for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 09:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Dec 2022 14:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59914 X-GNU-PR-Package: emacs Original-Received: via spool by 59914-submit@debbugs.gnu.org id=B59914.167059779020997 (code B ref 59914); Fri, 09 Dec 2022 14:57:02 +0000 Original-Received: (at 59914) by debbugs.gnu.org; 9 Dec 2022 14:56:30 +0000 Original-Received: from localhost ([127.0.0.1]:36551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3end-0005Sb-Cg for submit@debbugs.gnu.org; Fri, 09 Dec 2022 09:56:29 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:63408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3enX-0005SV-1z for 59914@debbugs.gnu.org; Fri, 09 Dec 2022 09:56:27 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 20612805D5; Fri, 9 Dec 2022 09:56:17 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 448558001A; Fri, 9 Dec 2022 09:56:15 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1670597775; bh=YgT6w4vFRM3SNngx53/dT76yc0/xLRwx+KVa4lNxZIE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Y75v1dBJktLfmJHCgoVB7/R7DV6gCV6sKP9iP+rnd9ZHGitsrslUgLIEuKHXI9qQY egZnJ6WBqn6Ybilzy0BxPbZ+NeCcXCngZcYu9M5H+QFZV4iWWUBm7sUmTLvE9mlFb7 fdFmNyTrgy7VFMZt/oiW3G4PM0G74IV9V32Ly6wuljYsVV7srM1MTi3R17yCPWEVhV 2soV5YOK8kM2lEXMNWTH4iSgUjDjvXgN36kJ8i4hzFjNOVi1AHd10hToaXeZUO5RCj zBfQbiQsi2/rSbQ9WTF9hSc0Dbd2GUy8QNTXsv9B/zGCDltC7knIfDRTf7BTgdT30V 8E4Q1C868+fQg== Original-Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EC93E122553; Fri, 9 Dec 2022 09:56:14 -0500 (EST) In-Reply-To: (Stefan Kangas's message of "Thu, 8 Dec 2022 16:11:22 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250404 Archived-At: > Stefan, does this look okay and make sense to you? Is pushing this all > that is needed, or do we need some manual intervention in addition? I think it will require manual intervention on `elpa.gnu.org` but I'll take care of that. > - ("bind-key" :url "https://github.com/jwiegley/use-package" > - :ignored-files ("LICENSE" "doc" "Makefile*" "bind-chords.el" "use-package*" > - "README.md" "NEWS.md") ;; These two are for use-package. > - :news "/dev/null" ;l Don't use use-package' s `NEWS.md`. > - :auto-sync t) > + ("bind-key" :core "lisp/use-package/bind-key.el") Looks fine. > - ("use-package" :url "https://github.com/jwiegley/use-package" > - :ignored-files ("LICENSE" "bind-*" "use-package-chords.el") > - :readme "README.md" > - :doc "use-package.texi" > - :news "NEWS.md" > - :auto-sync t) > + ("use-package" > + :core ("lisp/use-package/use-package-core.el" > + "lisp/use-package/use-package-delight.el" > + "lisp/use-package/use-package-diminish.el" > + "lisp/use-package/use-package-ensure.el" > + "lisp/use-package/use-package-jump.el" > + "lisp/use-package/use-package-lint.el" > + "lisp/use-package/use-package.el") > + :doc "use-package.texi") Can we use "lisp/use-package/" (and maybe the use `:ignored-files` to strip out `bind-keys.el` or maybe even move `bind-keys.el` outside of the `use-package` subdirectory)? Also I suspect you need to add "doc/misc/use-package.texi" to `:core` in order for the `:doc` to find the file. Have you tried the above recipe? > + ("use-package-ensure-system-package" > + :core ("lisp/use-package/use-package-ensure-system-package.el")) Why do we need this as a separate package? And while I'm here, I see in the doc: @lisp (use-package foo :ensure-system-package foo) @end lisp This will expect a global binary package to exist called @code{foo}. Should we use another name than "binary package"? In my part of the world these things are usually called "executables" or "programs", occasionally they're called "binaries" but I'd never heard them called "binary packages". Stefan