From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/undo-fu-session a6c4f73bc2: Cleanup: define functions side-effect-free Date: Mon, 03 Jul 2023 23:13:33 -0400 Message-ID: References: <168843602520.15656.10263776016888491607@vcs2.savannah.gnu.org> <20230704020025.7B95AC11DCA@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20102"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Campbell Barton To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 04 05:14:01 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGWUK-0004tn-5R for ged-emacs-devel@m.gmane-mx.org; Tue, 04 Jul 2023 05:14:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qGWU4-0006Ru-Hn; Mon, 03 Jul 2023 23:13:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGWU2-0006Od-Hd for emacs-devel@gnu.org; Mon, 03 Jul 2023 23:13:42 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGWU1-0006R0-4S for emacs-devel@gnu.org; Mon, 03 Jul 2023 23:13:42 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 06B9A10016C; Mon, 3 Jul 2023 23:13:40 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BAC2810011D; Mon, 3 Jul 2023 23:13:34 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1688440414; bh=lcv6TqJtSr/HWDbsxpXhEagEYKCCpwcRCNtBlgeH2Zo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=HnlikEKRIoQ1S93Clr8/DWJFtA9UKJXHke7+yxFxcxh9v7qLGsD7NpEoVLt7VKi7+ 3iUlyKeh6Q9qdNGMiCsaG+cbriKALjilhTgb9W/i/34QSKismUD+JSP1Sx4p/1sli0 VkBkrdm6yJkOYmjFl90fvz8CS3pgrEXVzxKJRvS6qW6WJaPFjxFtQWTwu5NpTQGJLI Z5CZOfjjE9ewlppXGiL3NLeRAVESm/wjQ5oNsw0KitqenWuhYD5uc0Qd8nUjnZ7Svx v6Bs9qPmSTs/GmPQgSTCF71Uk8VuT3ssRARw0hr8ekVGkJFtNpuYQFsYEORgU559Bk Blkmm0nUJrz+A== Original-Received: from pastel (69-165-155-162.dsl.teksavvy.com [69.165.155.162]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 967161207DF; Mon, 3 Jul 2023 23:13:34 -0400 (EDT) In-Reply-To: <20230704020025.7B95AC11DCA@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Mon, 3 Jul 2023 22:00:25 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307399 Archived-At: > (defun undo-fu-session--ensure-trailing-slash (dir) > "Return DIR with exactly one trailing slash." > + (declare (side-effect-free error-free)) > ;; Both "/tmp" and "/tmp//" result in "/tmp/" > (file-name-as-directory (directory-file-name dir))) Hmm... haven't checked the other ones, but this one is obviously a lie, since it will signal an error if you pass it, say, an integer. Stefan