From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master bb9133f09da: * lisp/emacs-lisp/ert.el (ert-run-tests-batch-and-exit): Inhibit interaction Date: Mon, 14 Aug 2023 11:05:10 -0400 Message-ID: References: <169195451549.1474.16374421496442723026@vcs2.savannah.gnu.org> <20230813192155.C53CEC295F9@vcs2.savannah.gnu.org> <87ttt22j2a.fsf@gmx.de> <18DBF0B1-8534-48C2-B5FE-4B324A93AB2A@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32547"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Michael Albinus , emacs-devel@gnu.org To: Mattias =?windows-1252?Q?Engdeg=E5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 14 17:06:05 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qVZ8v-0008D6-4c for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Aug 2023 17:06:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qVZ8E-0002tH-Kf; Mon, 14 Aug 2023 11:05:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVZ8C-0002sM-3c for emacs-devel@gnu.org; Mon, 14 Aug 2023 11:05:20 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVZ8A-0006Vc-Bc for emacs-devel@gnu.org; Mon, 14 Aug 2023 11:05:19 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A4F70442757; Mon, 14 Aug 2023 11:05:16 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1692025510; bh=U2lWgKCw3x3HwjBEKHYiQ8A2DUn3EV0BMBu/db9x49o=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=mGC6mpjmdAVsiQ1FtahXPYfBaLQQCW4PQR7+BJ4bqSh5tllT7dqfvZwOwvHFVTB52 TdjtIdik2stWeIT+DktX0oT6SAmO2Qe5cS6YtUmlQyOp+ERKgOhsZxLyuH3VriDNhA 4Fy9OuwSzaEhSQ01YXzkQoLAji8tTQjezHIAx4iE/l7k/zOZmZGT2owPInHcr/NYM/ oJSTX2N5tlb9BOZCoSv2mvaD+9qdkMec0WhWxNygAWeI9GqJu6033kSCC2NpUlAK9t xjhEesZoFswBRTCfG60UFRG7t922E44S9HFdkzElrEiBP0peSuJj3sWHjuICoX3IMb FGGOD0l04bNFA== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E4E5544275D; Mon, 14 Aug 2023 11:05:10 -0400 (EDT) Original-Received: from pastel (unknown [45.72.228.154]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C33891202A0; Mon, 14 Aug 2023 11:05:10 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Mon, 14 Aug 2023 10:39:26 -0400") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308740 Archived-At: > Oh, I think I see: `inhibit-interaction` is probably tested too early, > e.g. upon entry to `read-event` (which can return without user > interaction if there's enough `unread-command-events` and friends) > instead of upon entry to the actual code that waits for user input, so > it doesn't quite do what I thought it would. And even if we move the check to the actual place in `read_char` where we wait for user input, it's still too early because it burps in those places in the tests where we `read-event` only for the timeout (i.e. we do wait, but no user-interaction is needed). Stefan